Multithreading for faster camera frame access #1678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaynarisetti
suggested changes
Apr 25, 2022
Contributor
There was a problem hiding this comment.
Hi @Gaurav561
Just create an Issue for the same and mention this PR in the issue. It's just a contribution guideline of JdeRobot, to first create an Issue and then create a PR.
Adding comments in the code will help the maintainability of the code since multi-threading is added.
Also, you could explain what and why the changes are necessary. It just makes the reviewer's work easy :)
Author
|
Hi @akshaynarisetti , Created an Issue #1688 for this pr. I have also added comments in the code. The changes I made will help to speed up the process of frame access and decrease the inference time. Here, I have created a seperate thread which will run a loop to access the camera frames. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-threading implementation for faster frame access during live inferencing.