-
-
Notifications
You must be signed in to change notification settings - Fork 28
Introduce CMake fetchcontent and CMake Install Workflow #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Introduce CMake fetchcontent and CMake Install Workflow #480
Conversation
- CI Error when no files found - make libraries static - install tests and vulkan lib - Introduce CPack - Fix Clang-format issue moving to LLVM 21, which is now default on several platforms - simplify testing due to install workflow - Initialize SwapchainImages with the size parameter added as the creation of the swap chains was happening successfully but the size was not getting updated giving an index error. - Fix error on linux where Wayland was not being initialized properly. Wayland is the default for glfw in version 3.4 and in many desktop environments. GLFW_EXPOSE_NATIVE_* macro was defined for windows but not for the other Operating Systems
56cc9e4 to
f45414e
Compare
|
@JeanPhilippeKernel @jnyfah I'm not sure why this check is failing, however, I would like to request you to try the build artifacts on your systems. The main thing with the install workflow is to move what was in the Panzerfaust/net8.0..../publish folder is not going to the bin folder with the vulkan loader library in the lib folder. This means that downloading the release builds should be able to run on a user system easily. The program doesn't run because of the "Shader::CreateDescriptorLayout()" code runs out of vram when loading up the shaders. However, I believe that the "not running on mac and linux" issue may be resolved by this. |
|
Hey @MathewBenson |
|
my first observation will be to extract the vulkan related issue in a seperate PR - and as heads-up there is an on-going effort to fix the issue here : #479 |
- Being worked on by another branch.
e7ea056 to
e007150
Compare
- The GLFW_NATIVE macros are required for surface creation in the respective systems. - Currently it was hard-coded for windows only. - Added the required macros for linux and macos to remove the error that was in the Logs for vk_surface not created - Also added the __externals folder to gitignore so that it is not detected. Useful when switching branches and experimenting between the older and this version.
FetchContent Package Management
CMake Install
SwapChain Image Sizes
Wayland on Linux