Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 26, 2025

Both bump.sh, release.sh, and the Makefile check for pyproject.toml existence before proceeding. This is redundant as upstream validation ensures the file exists.

Changes

  • Removed pyproject.toml existence check from .rhiza/scripts/bump.sh
  • Removed pyproject.toml existence check from .rhiza/scripts/release.sh
  • Removed pyproject.toml existence check from Makefile install target
  • Removed pyproject.toml existence check from Makefile deptry target
  • Added clarifying comment in Makefile explaining the pyproject.toml assumption

The scripts and Makefile targets now proceed directly to their core functionality, reducing defensive checks that add no value.

[!WARNING]

Original prompt

This section details on the original issue you should resolve

<filter_complete></filter_complete>

<issue_title>Remove the constant checks if there is a pyproject.toml file</issue_title>
<issue_description>You can assume the file exists as validate would throw an error otherwise</issue_description>

Comments on the Issue (you are @copilot in this section)

Original prompt

This section details on the original issue you should resolve

<issue_title>Remove the constant checks if there is a pyproject.toml file</issue_title>
<issue_description>You can assume the file exists as validate would throw an error otherwise</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…e scripts

Co-authored-by: tschm <2046079+tschm@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove constant checks for pyproject.toml file Remove redundant pyproject.toml existence checks Dec 26, 2025
Copilot AI requested a review from tschm December 26, 2025 12:50
@tschm
Copy link
Member

tschm commented Dec 26, 2025

@copilot remove from the Makefile

Co-authored-by: tschm <2046079+tschm@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 26, 2025

@copilot remove from the Makefile

Done. Removed pyproject.toml existence checks from the Makefile in commit 18f4217.

Co-authored-by: tschm <2046079+tschm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the constant checks if there is a pyproject.toml file

2 participants