Skip to content

Switch to generic predictor pool #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baltzell merged 2 commits into from
Jan 7, 2026
Merged

Switch to generic predictor pool #1040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9702c83
add generic predictor pool
baltzell Jan 5, 2026
0c505c6
cleanup
baltzell Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions reconstruction/ai/src/main/java/org/jlab/service/ai/DCClsComboEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import ai.djl.ndarray.NDArray;
import ai.djl.ndarray.NDList;
import ai.djl.ndarray.NDManager;
import ai.djl.ndarray.types.Shape;
import ai.djl.repository.zoo.Criteria;
import ai.djl.repository.zoo.ModelNotFoundException;
import ai.djl.repository.zoo.ZooModel;
Expand All @@ -22,8 +21,6 @@
import ai.djl.translate.TranslatorContext;
import java.io.IOException;
import java.nio.file.Paths;
import java.util.concurrent.ArrayBlockingQueue;
import java.util.concurrent.BlockingQueue;
import java.util.logging.Level;
import java.util.logging.Logger;
import org.jlab.clas.reco.ReconstructionEngine;
Expand Down Expand Up @@ -57,27 +54,8 @@ public class DCClsComboEngine extends ReconstructionEngine {

final static int SUPERLAYERS = 6;

// -------- Predictor Pool --------
public static class PredictorPool {
final BlockingQueue<Predictor<float[][], float[]>> pool;
public PredictorPool(int size, ZooModel<float[][], float[]> model) {
pool = new ArrayBlockingQueue<>(size);
for (int i=0; i<size; i++) {
try {
pool.add(model.newPredictor());
} catch (Exception e) {
Logger.getLogger(PredictorPool.class.getName()).log(Level.WARNING, "Failed to create predictor", e);
}
}
}
public Predictor<float[][], float[]> take() throws InterruptedException { return pool.take(); }
public void put(Predictor<float[][], float[]> p) throws InterruptedException { if (p!=null) pool.put(p); }
public void shutdownAll() { for (Predictor p: pool) { try { p.close(); } catch (Exception ignored) {} } }
}

public DCClsComboEngine() {
super("DCClsComboEngine","tongtong","1.0");

}

@Override
Expand Down
20 changes: 0 additions & 20 deletions reconstruction/ai/src/main/java/org/jlab/service/ai/DCDenoiseEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
import ai.djl.translate.TranslateException;

import java.io.IOException;
import java.util.concurrent.BlockingQueue;
import java.util.concurrent.ArrayBlockingQueue;
import java.util.logging.Level;
import java.util.logging.Logger;

Expand All @@ -44,24 +42,6 @@ public class DCDenoiseEngine extends ReconstructionEngine {
ZooModel<float[][][], float[][][]> model;
PredictorPool predictors;

// -------- Predictor Pool --------
public static class PredictorPool {
final BlockingQueue<Predictor<float[][][], float[][][]>> pool;
public PredictorPool(int size, ZooModel<float[][][], float[][][]> model) {
pool = new ArrayBlockingQueue<>(size);
for (int i=0; i<size; i++) {
try {
pool.add(model.newPredictor());
} catch (Exception e) {
Logger.getLogger(PredictorPool.class.getName()).log(Level.WARNING, "Failed to create predictor", e);
}
}
}
public Predictor<float[][][], float[][][]> take() throws InterruptedException { return pool.take(); }
public void put(Predictor<float[][][], float[][][]> p) throws InterruptedException { if (p!=null) pool.put(p); }
public void shutdownAll() { for (Predictor p: pool) { try { p.close(); } catch (Exception ignored) {} } }
}

public DCDenoiseEngine() {
super("DenoiseEngine","lleztlab","1.0");
}
Expand Down
39 changes: 39 additions & 0 deletions reconstruction/ai/src/main/java/org/jlab/service/ai/PredictorPool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
package org.jlab.service.ai;

import ai.djl.inference.Predictor;
import ai.djl.repository.zoo.ZooModel;
import java.util.concurrent.ArrayBlockingQueue;
import java.util.concurrent.BlockingQueue;
import java.util.logging.Level;
import java.util.logging.Logger;

public class PredictorPool <T,U> {

final BlockingQueue<Predictor<T,U>> pool;

public PredictorPool(int size, ZooModel<T,U> model) {
pool = new ArrayBlockingQueue<>(size);
for (int i=0; i<size; i++) {
try {
pool.add(model.newPredictor());
} catch (Exception e) {
Logger.getLogger(PredictorPool.class.getName()).log(Level.WARNING, "Failed to create predictor", e);
}
}
}

public Predictor<T,U> take() throws InterruptedException {
return pool.take();
}

public void put(Predictor<T,U> p) throws InterruptedException {
if (p!=null) pool.put(p);
}

public void shutdownAll() {
for (Predictor p: pool) {
try { p.close(); }
catch (Exception ignored) {}
}
}
}