New recoil detector for RGH (2 sectors, 3 layers/sector of urwell, x/… #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y readout). Created new directory common-tools/clas-jcsg/src/main/java/org/jlab/detector/geant4/v2/RECOIL/ with Geant4Factory and StripFactory. Also crated reconstruction/recoil (hits, clusters, crosses). Tested on gemc, everything seems reasonable.
raffaelladevita
requested changes
Feb 7, 2025
| * | ||
| * @author bondi, devita, niccolai | ||
| */ | ||
| public class recoilCluster extends ArrayList<recoilStrip> { |
Collaborator
There was a problem hiding this comment.
According tto Java standards, the name of classes should start with a capital letter..can you make this (and the others) RecoilCluster?
| @@ -0,0 +1,108 @@ | |||
| package org.jlab.detector.geant4.v2.RECOIL; | |||
Collaborator
There was a problem hiding this comment.
Since RECOIL is not an acronym, maybe make it lower case?
Collaborator
Author
|
I have made the corrections, corrected conflicts and all seems ok. Do I have to redo another pull request? I am a bit lost now :-) |
raffaelladevita
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y readout). Created new directory common-tools/clas-jcsg/src/main/java/org/jlab/detector/geant4/v2/RECOIL/ with Geant4Factory and StripFactory. Also crated reconstruction/recoil (hits, clusters, crosses). Tested on gemc, everything seems reasonable.