Fix crash in DEventWriterREST when SYS_DIRC extrapolations are missing #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrstevenjlab
approved these changes
Jan 13, 2026
Contributor
jrstevenjlab
left a comment
jrstevenjlab
left a comment
There was a problem hiding this comment.
No problem to remove the unused variable. This should be merge once it passes the usual build test. That may need to wait until Alex returns next week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash in DEventWriterREST.cc observed when processing
2020 GlueX REST data. The code assumed that the SYS_DIRC entry always exists in the
DTrackFitter::extrapolations map and accessed it via .at(SYS_DIRC),
which can throw when the key is missing. The problematic variable was unused, so it has been removed,
preventing the crash.