Fixed crash when there are trailing delimiters at the end of a line#8
Open
2joy wants to merge 11 commits intoJensRantil:masterfrom
Open
Fixed crash when there are trailing delimiters at the end of a line#82joy wants to merge 11 commits intoJensRantil:masterfrom
2joy wants to merge 11 commits intoJensRantil:masterfrom
Conversation
Owner
|
Whoa! I'm happy this library is being used! Thanks for the fix. Would it be possible for you to add a test case, too? If too much work, could you paste some example code/CSV here and I'll make sure to add a test case. |
Travis CI was sunset in May 2021[1]. Will introduce Github Actions instead. [1] https://blog.travis-ci.com/2021-05-07-orgshutdown
Defaults to one hour[1]. [1] https://bors.tech/documentation/getting-started/
22: Enable Github Actions r=JensRantil a=JensRantil Co-authored-by: Jens Rantil <jens.rantil@normative.io>
19: feat(writer): introduce non-numeric & non-empty quote mode r=JensRantil a=JensRantil Co-authored-by: Tim Otto <tim@timotto.io>
Nice to have that done automagically.
23: chore(ci): delete branch after merge r=JensRantil a=JensRantil Nice to have that done automagically. Co-authored-by: Jens Rantil <jens.rantil@normative.io>
...not just pushes that are related to Bors.
24: chore(ci): run tests on all pushes r=JensRantil a=JensRantil ...not just pushes that are related to Bors. bors merge Co-authored-by: Jens Rantil <jens.rantil@normative.io>
Owner
@2joy Ping. Spent a few minutes yesterday trying to reproduce this but was unable to. Do you think you could paste an example CSV file here? |
Owner
|
Hello! There are merge conflicts here. Would you mind rebasing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used a piece of your code to fix the problem, you can see by comments. I needed to fix it to get https://github.com/lukasmartinelli/pgfutter works properly. I built the new version of pgfutter with fixed go-csv. After 2 week of every day usage there are no isues.