fix: extract full session_name from sessionId instead of just first segment

[JeongJaeSoon]

Summary

Fixed session name extraction to display the full session_name from sessionId instead of just the workspace type (temp/project).

Changes

• Updated regex pattern in extractSessionNameFromId function
• Changed from [^-]+ to .+ to capture entire session name
• Now extracts full session names like "my_session_name" instead of just "temp"

Test Plan

• Verify session names display correctly in UI
• Test with various sessionId formats

Fixes #2

Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Improved session name extraction to support names containing dashes.

[coderabbitai]

Walkthrough

The regular expression in the extractSessionNameFromId function within src/main.ts was updated to capture session names that may include dashes, by matching everything after -workspace-${sessionType}-. Associated comments were revised to accurately describe the new extraction logic. No other functional or structural changes were made.

Changes

Cohort / File(s)	Change Summary
Regex Extraction Logic Update src/main.ts	Modified the regex in extractSessionNameFromId to allow session names with dashes; updated comments to match new logic.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant MainTS

    Caller->>MainTS: extractSessionNameFromId(sessionId, sessionType)
    MainTS->>MainTS: Use updated regex to extract session name (allowing dashes)
    MainTS-->>Caller: Return extracted session name or fallback

Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Assessment against linked issues

Objective	Addressed	Explanation
Extract session name from sessionId, allowing for dashes and variable session types (#2)	✅

Possibly related PRs

• feat: extract session names from sessionId for better UI display #15: Both PRs modify the extractSessionNameFromId function in src/main.ts to improve how session names are extracted from sessionId strings, with the main PR updating the regex to allow dashes in session names while the retrieved PR introduces the function and its initial extraction logic.

Poem

In the land of code where sessions roam,
A regex tweak brings names back home.
Now dashes dance in session strings,
Extraction logic spreads its wings.
Rabbits cheer with every run—
Accurate names for everyone!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 88e8cde and b34f74a.

📒 Files selected for processing (1)

• src/main.ts (1 hunks)

🔇 Additional comments (1)

src/main.ts (1)

12-14: Confirm extractSessionNameFromId Regex Change

• Location: src/main.ts, lines 12–14 in extractSessionNameFromId.
• What’s changed:
  • Regex updated from /\-workspace\-[^\-]+\-[^\-]+/ to /\-workspace\-[^\-]+\-(.+)/.
  • Comments revised to “extract everything after -workspace-${sessionType}-” rather than just the first dash-delimited segment.
• Why it matters:
  • The new (.+) correctly captures full session names containing dashes.
  • Fallback split-and-last-segment logic is unchanged.

We didn’t find any concrete sessionId examples in the codebase. Because (.+) is greedy, please verify:

• That sessionId values never include extra suffixes beyond the intended session name.
• If they do, refine the regex (e.g. anchor to end-of-string or add a lookahead) to avoid capturing unintended characters.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch claude/issue-2-20250730-1849

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[claude]

Claude finished @JeongJaeSoon's task —— View job

---

Code Review Completed ✅

Reviewing PR #16: fix session name extraction logic

Todo List:

• Read and analyze src/main.ts changes
• Check for potential bugs and edge cases
• Evaluate performance implications
• Assess security concerns
• Review test coverage
• Provide comprehensive feedback

---

Review Summary

This PR fixes session name extraction in the extractSessionNameFromId function by changing the regex pattern from ([^-]+) to (.+) to capture full session names that may contain dashes.

✅ Code Quality & Best Practices

Good:

• Clear, descriptive comments explaining the regex pattern
• Proper fallback logic with multiple strategies
• Good function structure and readability
• Meaningful variable names

⚠️ Potential Issues & Edge Cases

1. Greedy Matching Behavior

• Issue: The new pattern (.+) is greedy and will match everything to the end of the string
• Impact: Could capture unwanted trailing characters or whitespace
• Example: For sessionId -Users-john-workspace-temp-my_session_name-extra, it would capture my_session_name-extra

2. Empty/Whitespace Session Names

• Issue: Pattern doesn't validate that captured content is meaningful
• Impact: Could result in empty strings or whitespace-only session names
• Suggested fix: Consider adding validation: match[1].trim() and check if non-empty

3. Input Validation

• Issue: No validation of sessionId format before regex matching
• Impact: Could fail silently on malformed inputs

🔒 Security Concerns

Low Risk:

• Input is from internal ccusage tool, not user input
• No code injection possibilities with current usage
• Session names are displayed in UI but appear to be text-only

⚡ Performance Considerations

Acceptable:

• Regex complexity is minimal ((.+) vs ([^-]+))
• Function is called only when processing session data
• No performance regressions expected

🧪 Test Coverage

Missing:

• No unit tests exist for this function
• Recommendation: Add tests for common sessionId patterns:

  // Test cases to consider:
  // -Users-john-workspace-temp-my_session_name
  // -Users-john-workspace-project-my-project-name
  // -Users-john-workspace-temp-session_with_underscores
  // -Users-john-workspace-temp-session-with-dashes

💡 Recommendations

1. Add input sanitization:

   if (match && match[1]) {
     const sessionName = match[1].trim();
     return sessionName || 'session'; // fallback if empty after trim
   }

2. Consider adding unit tests to prevent regressions

3. Add JSDoc documentation for the function parameters and return value

📋 Conclusion

Approve with minor suggestions. The change correctly addresses the issue of extracting full session names containing dashes. The implementation is straightforward and maintains existing fallback logic. Consider the input sanitization suggestion to make it more robust.

---