Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions .github/workflows/database_update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ name: Database Update

on:
push:
branches:
- 'main'
schedule:
- cron: '0 12 * * SUN'

Expand All @@ -10,16 +12,16 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: checkout repo content
uses: actions/checkout@v3
uses: actions/checkout@v6
- name: pull changes
run: git pull https://${{secrets.PAT}}@github.com/JerBouma/FinanceDatabase.git main
- name: setup python
uses: actions/setup-python@v4
uses: actions/setup-python@v6
with:
python-version: '3.13'
- run: pip install "pandas[excel]" financedatabase
- name: Add New Tickers and Update Old Ones
uses: jannekem/run-python-script-action@v1
uses: jannekem/run-python-script-action@v1.8
with:
script: |
import glob
Expand Down Expand Up @@ -285,16 +287,16 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: checkout repo content
uses: actions/checkout@v3
uses: actions/checkout@v6
- name: pull changes
run: git pull https://${{secrets.PAT}}@github.com/JerBouma/FinanceDatabase.git main
- name: setup python
uses: actions/setup-python@v4
uses: actions/setup-python@v6
with:
python-version: '3.10'
- run: pip install "pandas[excel]" financedatabase
- name: Update Compressions
uses: jannekem/run-python-script-action@v1
uses: jannekem/run-python-script-action@v1.8
with:
script: |
import glob
Expand Down Expand Up @@ -345,16 +347,16 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: checkout repo content
uses: actions/checkout@v3
uses: actions/checkout@v6
- name: pull changes
run: git pull https://${{secrets.PAT}}@github.com/JerBouma/FinanceDatabase.git main
- name: setup python
uses: actions/setup-python@v4
uses: actions/setup-python@v6
with:
python-version: '3.10'
- run: pip install "pandas[excel]" financedatabase
- name: Update categories
uses: jannekem/run-python-script-action@v1
uses: jannekem/run-python-script-action@v1.8
with:
script: |
import glob
Expand Down Expand Up @@ -455,16 +457,16 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: checkout repo content
uses: actions/checkout@v3
uses: actions/checkout@v6
- name: pull changes
run: git pull https://${{secrets.PAT}}@github.com/JerBouma/FinanceDatabase.git main
- name: setup python
uses: actions/setup-python@v4
uses: actions/setup-python@v6
with:
python-version: '3.13'
- run: pip install pandas
- name: Refresh the statistics tables in README.md
uses: jannekem/run-python-script-action@v1
uses: jannekem/run-python-script-action@v1.8
with:
script: |
import glob
Expand Down Expand Up @@ -569,14 +571,14 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: checkout repo content
uses: actions/checkout@v3
uses: actions/checkout@v6
- name: setup python
uses: actions/setup-python@v4
uses: actions/setup-python@v6
with:
python-version: '3.10'
- run: pip install "pandas[excel]" financedatabase
- name: Check GICS Categorisation
uses: jannekem/run-python-script-action@v1
uses: jannekem/run-python-script-action@v1.8
with:
script: |
import glob
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout Code
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Install uv
uses: astral-sh/setup-uv@v5
uses: astral-sh/setup-uv@v7
with:
enable-cache: true

- name: Setup Python 3.10
uses: actions/setup-python@v5
uses: actions/setup-python@v6
with:
python-version: "3.10"
architecture: x64
Expand All @@ -39,7 +39,7 @@ jobs:
name: Markdown Linting
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
name: Check out the code
- name: Lint Code Base
uses: docker://avtodev/markdown-lint:v1
6 changes: 3 additions & 3 deletions .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ jobs:
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Install uv
uses: astral-sh/setup-uv@v5
uses: astral-sh/setup-uv@v7
with:
enable-cache: true

- name: Set up Python
uses: actions/setup-python@v5
uses: actions/setup-python@v6
with:
python-version: '3.10'

Expand Down
22 changes: 22 additions & 0 deletions tests/test_invariants.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

from __future__ import annotations

from pathlib import Path

import pandas as pd

import financedatabase as fd


Expand Down Expand Up @@ -76,3 +80,21 @@ def test_no_isin_collisions_across_asset_classes() -> None:
f"({len(shared)} total): {sorted(shared)[:5]}"
f"{' ...' if len(shared) > 5 else ''}"
)


def test_delisted_is_strictly_boolean() -> None:
"""`delisted` must be a real bool column: no NaN, no stray types.

`Equities.select()` filters with `~equities["delisted"]`, which only
negates correctly on a bool dtype, so anything else is dirty data.
"""
files = sorted(Path("database/equities").glob("*.csv"))
assert files, "no equities CSVs found under database/equities/"
delisted = pd.concat([pd.read_csv(f, index_col=0)["delisted"] for f in files])
if delisted.dtype != bool:
offenders = delisted[~delisted.isin([True, False])]
raise AssertionError(
f"'delisted' is not bool dtype (got {delisted.dtype}); "
f"{len(offenders)} invalid/NaN value(s), e.g. "
f"{offenders.index[:5].tolist()}"
)