Skip to content

Guard against NaN currency codes in portfolio conversion #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JerBouma merged 1 commit into from
Mar 13, 2026
Merged

Guard against NaN currency codes in portfolio conversion #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion financetoolkit/portfolio/portfolio_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,7 +830,19 @@ def collect_historical_data(
self._currency_column # type: ignore
].items():
data_currency = self._historical_statistics.loc["Currency", ticker]
if self._historical_statistics.loc["Currency", ticker] != currency:

# Skip when either currency code is missing or NaN,
# otherwise a bogus symbol like "NAN=X" gets sent to
# Yahoo Finance and triggers a 404.
if (
not currency
or not data_currency
or pd.isna(currency)
or pd.isna(data_currency)
):
continue

if data_currency != currency:
currency_conversions[ticker] = (
f"{currency}{data_currency}=X".upper()
)
Expand Down
Loading