Fix Enter key not triggering onClick on clickable elements on web (CMP-9386) #2653
+45
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P-9386) The clickable modifier triggers onClick on keyup events (for Enter/Space), but NativeInputEventsProcessor only processed keydown events. This caused clickable elements to show ripple effect on Enter press but never invoke the onClick callback. Fix: Process keyup events for non-character keys (like Enter, Space, arrows) in NativeInputEventsProcessor, allowing them to reach Compose and trigger clickable's keyup-based onClick logic.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The clickable modifier triggers onClick on keyup events (for Enter/Space), but NativeInputEventsProcessor only processed keydown events. This caused clickable
elements to show ripple effect on Enter press but never invoke the onClick callback.
Fix: Process keyup events for non-character keys (like Enter, Space, arrows) in NativeInputEventsProcessor.
Fixes https://youtrack.jetbrains.com/issue/CMP-9386
Testing
Added testEnterKeyEventProcessing test that verifies both keydown and keyup events are sent to Compose for Enter key.
Release Notes
Fixes - Web