Fix focus navigation from TextField to non-TextField on web (CMP-9388) #2654
+123
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When focus moves from a single-line TextField to a non-TextField focusable element (or from a read-only TextField), the backing HTML input is disposed but the canvas doesn't receive DOM focus. This leaves the browser with no element to receive subsequent keyboard events, causing Tab navigation to break. Fix: Call focusFallbackElement.focus() in stopInput() to give the canvas DOM focus when the backing input is removed.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When focus moves from a single-line TextField to a non-TextField focusable element (or from a read-only TextField), the backing HTML input is disposed but the canvas
doesn't receive DOM focus. This leaves the browser with no element to receive subsequent keyboard events, causing Tab navigation to break.
Fix: Call focusFallbackElement.focus() in stopInput() to give the canvas DOM focus when the backing input is removed.
Fixes https://youtrack.jetbrains.com/issue/CMP-9388
Testing
Added canTabThroughReadOnlyTextField test that verifies Tab navigation works correctly through a sequence of editable → editable → read-only → editable TextFields.
Release Notes
Fixes - Web
(https://youtrack.jetbrains.com/issue/CMP-9388)