compose/foundation: support prefetch scheduler to enable PausableComposition in LazyLayout #2656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osition in LazyLayout
MatkovIvan
requested changes
Jan 5, 2026
Member
There was a problem hiding this comment.
We cannot change public common API in the fork. This change cannot be merged
| } | ||
| } | ||
| } | ||
| // FIXME: We've only implemented the corresponding prefetchScheduler for UIKitMain, but the configuration for other variants is too complex and requires a simpler solution. Currently, comments can only be added through the UIKitMain build. |
Member
There was a problem hiding this comment.
The project is not buildable in without providing actuals. Another blocker here
| @OptIn(ExperimentalForeignApi::class) | ||
| @Suppress("DEPRECATION") // b/420551535 | ||
| @ExperimentalFoundationApi | ||
| internal class SkikoPrefetchScheduler( |
Member
There was a problem hiding this comment.
It doesn't seem that foundation module is the right place for this logic. I guess it should be a part of the existing CADisplayLink flow inside ui module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe proposed changes and the issue being fixed
Support prefetch scheduler in UIKit(iosMain) to enable PausableComposition in LazyLayout
Fixes CMP-9398
TODO: Compilation of non-iOS variants under the legacy skikoMain source set
Testing
(Optional) Describe how you tested your changes (provide a snippet or/and steps)
(Optional) This should be tested by QA
Release Notes
Section - Subsection