Skip to content

Don't trigger the accented char input hack when there's an active composition#2763

Merged
m-sasha merged 1 commit intojb-mainfrom
m-sasha/fix-accented-input-with-composition
Feb 13, 2026
Merged

Don't trigger the accented char input hack when there's an active composition#2763
m-sasha merged 1 commit intojb-mainfrom
m-sasha/fix-accented-input-with-composition

Conversation

@m-sasha
Copy link

@m-sasha m-sasha commented Feb 13, 2026

Don't trigger the accented char input hack when there's an active composition.
Also clear needToDeletePreviousChar on every InputMethodEvent to prevent hanging on to it when the trigger was sent a long time ago.

Fixes https://youtrack.jetbrains.com/issue/CMP-9761

Testing

Tested manually and added a unit test.

This should be tested by QA

Release Notes

Fixes - Desktop

  • Fixed an issue with "Pinyin - Simplified" input in BasicTextField(TextFieldState) when the temporary (composed) english text was not removed when the composition is committed.

@m-sasha m-sasha requested a review from igordmn February 13, 2026 12:11
@m-sasha m-sasha merged commit 5f23f8e into jb-main Feb 13, 2026
26 of 27 checks passed
@m-sasha m-sasha deleted the m-sasha/fix-accented-input-with-composition branch February 13, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants