Resources improvements for native macOS app#5219
Conversation
|
@terrakok Skiko is now already updated on jb-main branch. Would it be possible to run CI on this PR to check if all is working? |
e22b11b to
e5d45f2
Compare
|
@terrakok tested on an Intel Mac and the tests now pass with the updated skiko version: In gradle-plugins module I set |
|
Could this be reviewed, please? Is there anything that needs to be changed? |
|
Apologise, the PR was reverted. Could you fix the CI failures and make a new PR? ubuntu/windows: macos: |
|
|
|
@igordmn @terrakok thanks for letting me know, opened a new PR: #5245 It would be nice if TeamCity works on PRs as well, just like how Ktor does it. That would make contributing easier. ubuntu/windows: Reproduced on Ubuntu, caused by a bug in macos: My bad, I thought GitHub CI would override Now there is only failed test on GitHub CI due to MissingResourceException, which is because CI does not use latest version of resources component library, it has changes which are required for the test to succeed. |
This PR fixes compose resources for native macOS app (see currently broken chat app using runDebugExecutableMacosArm64). This PR also adds support for embedding resources into native macOS framework. Similar to how it works on iOS. This allows using the macOS compose code in an Xcode project. Just like iOS, using kotlin code as framwork. Then call the main function from the Xcode project to run the compose app. #5219 #5169 ## Testing - For executable: run chat app using runDebugExecutableMacosArm64 - For framework: Tested by adding macOS support to the iOS Xcode project in chat app (not in this PR). Can add the sample app if needed. There were also tests added to verify this. ## Release Notes N/A

See old PR for details: #5169
Requires skiko update (JetBrains/compose-multiplatform-core#1804)