Skip to content

Remove Surface caching in the Apple graphics context #5267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pjBooms merged 1 commit into from
Mar 26, 2025
Merged

Remove Surface caching in the Apple graphics context #5267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions benchmarks/multiplatform/benchmarks/src/appleMain/kotlin/GraphicsContext.apple.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,8 @@ fun graphicsContext() = object : GraphicsContext {
private val device = MTLCreateSystemDefaultDevice() ?: throw IllegalStateException("Can't create MTLDevice")
private val commandQueue = device.newCommandQueue() ?: throw IllegalStateException("Can't create MTLCommandQueue")
private val directContext = DirectContext.makeMetal(device.objcPtr(), commandQueue.objcPtr())
private var cachedSurface: Surface? = null

override fun surface(width: Int, height: Int): Surface {
val oldSurface = cachedSurface

if (oldSurface != null && oldSurface.width == width && oldSurface.height == height) {
return oldSurface
}

val descriptor = MTLTextureDescriptor()
descriptor.width = width.toULong()
descriptor.height = height.toULong()
Expand All @@ -51,9 +44,7 @@ fun graphicsContext() = object : GraphicsContext {
SurfaceColorFormat.BGRA_8888,
ColorSpace.sRGB,
SurfaceProps(pixelGeometry = PixelGeometry.UNKNOWN)
).also {
cachedSurface = it
} ?: throw IllegalStateException("Can't create Surface")
) ?: throw IllegalStateException("Can't create Surface")
}

override suspend fun awaitGPUCompletion() {
Expand Down
Loading