Use png image instead of a vector image in AnimatedVisibility benchmark #5275
Closed
Use png image instead of a vector image in AnimatedVisibility benchmark #5275
Conversation
…rk in preparation for D8 benchmarks D8 environment misses some APIs including a parser of xml. Also, make sure the web targets process the asynchronous fetch resources operations by yielding the event loop. Otherwise, a benchmark would skip a part of the workload.
eymar
changed the title
Member
Author
|
I'm closing this PR in favor of #5277 which contains the changes from this PR too. |
eymar
added a commit
that referenced
this pull request
Apr 29, 2025
- Updated the README.md with the description of benchmarks (might be useful to external parties) - customized a runner for D8 - added a `warmupCount` parameter to `runBenchmarks`, because it's required for Jetstream3 (a set of benchmarks) that there is no warmup (they skip it) - Added a smooth scroll variant of LazyGrid + variants with LaunchedEffect in grid cells for coroutines usage. - Added a new class `Config`. Object `Args` is simplified, it's purpose is to simply parse the arguments and produce a instance of `Config`. The usages of `Args` were replaced by `Config`, except the parsing in fun main. - Renamed Example1 to MultipleComponents - Also added MultipleComponents-NoVectorGraphics for D8 - it's similar to MultipleComponents but doesn't use vector icons. Fixes https://youtrack.jetbrains.com/issue/CMP-6942 Note: it's based on this PR #5275 ## Testing Manually run the benchmarks ## Release Notes N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's necessary in preparation for D8 benchmarks, since D8 environment misses some APIs including a parser of xml.
Also, make sure the web targets process the asynchronous fetch resources operations by yielding the event loop. Otherwise, a benchmark would skip a part of the workload.
Testing
N/A
Release Notes
N/A