Skip to content

Merge recent fixes into 1.8#5282

Merged
Kpotko merged 2 commits intorelease/1.8from
master-to-1.8
Apr 15, 2025
Merged

Merge recent fixes into 1.8#5282
Kpotko merged 2 commits intorelease/1.8from
master-to-1.8

Conversation

@MatkovIvan
Copy link
Member

Merge recent fixes into 1.8

DO NOT SQUASH

Release Notes

N/A

terrakok and others added 2 commits April 14, 2025 13:49
Fixes
https://youtrack.jetbrains.com/issue/CMP-7577/Desktop-runRelease-crash-when-upgrade-to-CMP-1.8.0-alpha02
Fixes
https://youtrack.jetbrains.com/issue/CMP-3818/Update-ProGuard-to-version-7.4-to-support-new-Java-versions
Fixes
https://youtrack.jetbrains.com/issue/CMP-4883/Default-Proguard-rules-cause-release-task-failure-when-using-Material-3-instead-of-2-in-Compose-Desktop

Targeting 1.8.0

The rules was added by testing our current examples. The comprehensive
rules are only possible if we run [all tests with
ProGuard](https://youtrack.jetbrains.com/issue/CMP-3404/Run-all-Compose-tests-with-ProGuard-on).

Also, each rule wasn't investigated thoroughly, in some cases it might a
valid rule, in some cases a ProGuard bug.

The auto integration checks on CI will be added in
https://youtrack.jetbrains.com/issue/CMP-7970/Add-integration-checks-for-all-libraries.


## Testing
`./gradlew runRelease` works in:
- https://kmp.jetbrains.com
- all examples

## Release Notes
### Features - Desktop
- The default ProGuard version is set to 7.7.0
- If there are any new errors in the release build, update [the ProGuard
rules](https://www.jetbrains.com/help/kotlin-multiplatform-dev/compose-native-distribution.html#minification-and-obfuscation)
- A usual workaround is to add `-keep class` for the associated with
error class in "Location:"
- If the error contains `androidx.` package, it might a Compose bug,
please report in https://youtrack.jetbrains.com/issues/CMP. The `-keep
class` workaround should also work in this case.
- _(prerelease fix)_ `./gradlew runRelease` doesn't crash with
`java.lang.VerifyError`
@MatkovIvan MatkovIvan requested a review from Kpotko April 15, 2025 07:06
@Kpotko Kpotko merged commit 2e36a87 into release/1.8 Apr 15, 2025
23 of 25 checks passed
@Kpotko Kpotko deleted the master-to-1.8 branch April 15, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants