Skip to content

Fix AGP 9.0.0-alpha01 compatibility for compose resources #5385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simonlebras wants to merge 2 commits into from
Closed

Fix AGP 9.0.0-alpha01 compatibility for compose resources #5385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7a198e
Fix AGP 9.0.0-alpha01 compatibility for compose resources
simonlebras Aug 17, 2025
8d21973
Upgrade Android Gradle Plugin to 8.10.1
simonlebras Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/resources/AndroidResources.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ private fun Project.configureAndroidComposeResources(
moduleResourceDir: Provider<File>?
) {
logger.info("Configure compose resources with KotlinMultiplatformAndroidComponentsExtension")
androidComponents.onVariant { variant ->
androidComponents.onVariants { variant ->
val variantAssets = getAndroidKmpComponentComposeResources(kotlinExtension, variant.name)
configureGeneratedAndroidComponentAssets(
variant.name,
Expand Down
2 changes: 1 addition & 1 deletion gradle-plugins/gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
kotlin = "2.2.0-RC2"
gradle-download-plugin = "5.5.0"
kotlin-poet = "2.1.0"
plugin-android = "8.9.1"
plugin-android = "8.10.1"
Copy link
Author

@simonlebras simonlebras Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onVariants is only available with AGP 8.10+

Copy link
Member

@terrakok terrakok Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, how does it work if user uses AGP 8.9?

Copy link
Author

@simonlebras simonlebras Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not compile unfortunately. It either does not work on 8.9 (with the fix) or on 9.0 (without the fix).

shadow-jar = "8.1.1"
publish-plugin = "1.2.1"

Expand Down