Bundle Compose Hot Reload Gradle plugin into the Compose Gradle plugin #5444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjBooms
force-pushed
the
pjBooms/embed-compose-hot-reload-plugin
branch
from
2195620 to
a800d3f
Compare
MatkovIvan
reviewed
Oct 6, 2025
| # A version of Gradle plugin, that will be published, | ||
| # unless overridden by COMPOSE_GRADLE_PLUGIN_VERSION env var. | ||
| deploy.version=9999.0.0-SNAPSHOT | ||
| hotreload.version=1.0.0-beta08 |
There was a problem hiding this comment.
I guess Ii's supposed to be configured on CI, here is the place only for some placeholder
cc @igordmn
There was a problem hiding this comment.
It is better to configure it only here, not on CI.
Because it is a dependency version, not a version of the building component.
There was a problem hiding this comment.
It is usually better to define such versions in lib.versions.toml, not in gradle.properties
| } | ||
| } | ||
| } | ||
| jvmToolchain { |
There was a problem hiding this comment.
It seems it will require JDK 11 to be installed that won't be a case on CI soon.
I'd suggest approach like here - 51a87ca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compose Hot Reload Gradle plugin are bundled into the Compose Gradle plugin.
Fixes CMP-8885
Testing
Integration tests added
This should be tested by QA
Release Notes
Highlights - Multiple Platforms