Deprecate org.jetbrains.compose.ui.tooling.preview.Preview #5453
Conversation
… in favor of androidx.compose.ui.tooling.preview.Preview
MatkovIvan
left a comment
MatkovIvan
left a comment
There was a problem hiding this comment.
Please deprecate PreviewParameterProvider and alias in gradle plugin too
…nd PreviewParameterProvider as well
pjBooms
force-pushed
the
pjBooms/deprecate-jetbrains-preview
branch
from
75a25db to
06001d2
Compare
Deprecated, thanx |
terrakok
left a comment
terrakok
left a comment
There was a problem hiding this comment.
Isn't better to wrap package and module names into backticks or square brackets?
| @Deprecated( | ||
| "Use org.jetbrains.compose.ui:ui-tooling-preview module instead", | ||
| ReplaceWith("compose.preview") | ||
| ) | ||
| val uiToolingPreview = composeDependency("org.jetbrains.compose.components:components-ui-tooling-preview") |
There was a problem hiding this comment.
In this case, I'd avoid to use ReplaceWith because the message and the action is counterintuitive 🤯
There was a problem hiding this comment.
It is just for users convinience. compose.preview is alias to org.jetbrains.compose.ui:ui-tooling-preview. Until we have the DSL at all, it seems we can just replace
I thought about it but grepped |
|
@pjBooms Please change "Highlights" to "Migration Notes" in release notes. Rules for choosing is documented here - https://github.com/JetBrains/compose-multiplatform/blob/master/tools/changelog/PR_FORMAT.md#possible-sections |
|
@MatkovIvan done, thanx for noting it |
Deprecate
org.jetbrains.compose.ui.tooling.preview.Previewannotation in favor ofandroidx.compose.ui.tooling.preview.PreviewFixes CMP-4869
Release Notes
Migration Notes - Multiple Platforms
org.jetbrains.compose.ui.tooling.preview.Previewannotation in favor ofandroidx.compose.ui.tooling.preview.Previewto reduce variety of Preview annotations