Skip to content

Provide platform specific constraints for Gradle dependency resolution for desktop targets#5545

Open
kropp wants to merge 2 commits intomasterfrom
kropp/skiko-awt-runtime
Open

Provide platform specific constraints for Gradle dependency resolution for desktop targets#5545
kropp wants to merge 2 commits intomasterfrom
kropp/skiko-awt-runtime

Conversation

@kropp
Copy link
Member

@kropp kropp commented Feb 27, 2026

This allows to correctly resolve skiko-awt-runtime based on current OS and CPU architecture, replacing compose.desktop.currentOs

Fixes CMP-9175 Introduce a single desktop dependency for all platforms

Testing

On desktop target, replacing the compose.desktop.currentOs with org.jetbrains.compose.desktop:desktop:1.11.0-alpha04 should work without any other changes on all OS

Release Notes

N/A

…n for desktop targets

This allows to correctly resolve skiko-awt-runtime based on current OS and CPU architecture, replacing `compose.desktop.currentOs`
@kropp kropp requested review from igordmn and terrakok February 27, 2026 15:57
}
})
} catch (_: Throwable) {
project.logger.debug("Skipping os/arch constraint for config ${configuration.name}")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this error not expected? Then it is better to print the stacktrace.

Copy link
Member

@terrakok terrakok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need some tests for that

Comment on lines +138 to 141
dependencies {
implementation(libs.compose.desktop)
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need it here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants