-
Notifications
You must be signed in to change notification settings - Fork 807
Tests maintenance: Add Neovim skip descriptions to ShiftLeftTest #1443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests maintenance: Add Neovim skip descriptions to ShiftLeftTest #1443
Conversation
Added description parameters to all @TestWithoutNeovim annotations in ShiftLeftTest to clarify why these tests are excluded from Neovim verification: - Test with DIFFERENT reason now explains caret positioning behavior - Tests with OPTION reason now document which option behavior is tested 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Code ReviewOverall Assessment: Good improvement to test documentation. The added descriptions help clarify why tests are excluded from Neovim verification. Issues Found:
Style: Descriptions should explain the specific behavioral difference or reason for skipping, not just restate what the test does. Compare with other tests in the codebase (e.g., "This test freezes", "bad replace term codes"). Test Coverage: ✓ All 4 @TestWithoutNeovim annotations now have descriptions |
|
|
||
| class ShiftLeftTest : VimTestCase() { | ||
| @TestWithoutNeovim(SkipNeovimReason.DIFFERENT) | ||
| @TestWithoutNeovim(SkipNeovimReason.DIFFERENT, "Caret positioning after shift with motion") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description is too vague. The test shows that after <W (shift left with motion), IdeaVim positions the caret at the first non-blank character (column 0), but Neovim would keep it at the same visual column (around column 31). Consider: "IdeaVim moves caret to first non-blank after shift, Neovim preserves column"
| } | ||
|
|
||
| @TestWithoutNeovim(SkipNeovimReason.OPTION) | ||
| @TestWithoutNeovim(SkipNeovimReason.OPTION, "Tests default startofline option behavior") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description doesn't explain why Neovim is skipped. These tests verify IdeaVim's specific option implementation, not Neovim compatibility. Consider: "Verifies IdeaVim startofline option implementation"
| } | ||
|
|
||
| @TestWithoutNeovim(SkipNeovimReason.OPTION) | ||
| @TestWithoutNeovim(SkipNeovimReason.OPTION, "Tests nostartofline option behavior") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as line 41 - focus on why it's excluded from Neovim testing rather than what the test does.
| } | ||
|
|
||
| @TestWithoutNeovim(SkipNeovimReason.OPTION) | ||
| @TestWithoutNeovim(SkipNeovimReason.OPTION, "Tests nostartofline option with caret at end of line") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as line 41 - describe the IdeaVim-specific behavior being tested rather than restating the test name.
Summary
Changes Made
Updated all 4 @TestWithoutNeovim annotations in ShiftLeftTest.kt:
This improves test documentation and makes it clearer why these tests are excluded from Neovim verification.
🤖 Generated with Claude Code