MP-5395 in between interface

[bric3]

@LChernigovskaya @udalov Here's the followup to #885

In particular for this #885 (comment)

Reference : MP-5395

Now when an interface in a plugin extends an interface of the platform that has a default method using an internal type. And that plugin interface is compiled, that interface will be generated with a DefaultImpls that will "forward" the call to the DefaultImpls of this parent interface.

classDiagram
    PlatformInterface <|-- PluginInterface

    class PlatformInterface{
      void defaultUsingInternalType(InternalType)
    }
    class PlatformInterfaceDefaultImpls{
      void defaultUsingInternalType(InternalType)
    }
    class PluginInterface {
    }
    class PluginInterfaceDefaultImpls{
      static void defaultUsingInternalType(InternalType)
    }

Loading

Ignore the missing $ in the schema above as mermaid don't like them in the class names.

An interesting bit is the PluginInterface$DefaultImpls generated by Kotlin is an inner class of both

• PlatformInterface
• PluginInterface

In this case the method forwarder is different as it is a static method in this case.

---

Also the previous implementation only handled parameters that were references, this limitation is now lifted.

[bric3]

Test are failing locally also for a reason that escapes me at this time.

https://github.com/JetBrains/intellij-plugin-verifier/actions/runs/5644840413/job/15289536907#step:7:199

com.jetbrains.pluginverifier.tests.VerificationTest > check that all problems are found FAILED
    java.lang.AssertionError at VerificationTest.kt:156

But locally I have the same test failing with this output.

/*expected(PROBLEM)
Package 'kotlin' is not found

Package 'kotlin' is not found along with its 2 classes.
Probably the package 'kotlin' belongs to a library or dependency that is not resolved by the checker.
It is also possible, however, that this package was actually removed from a dependency causing the detected problems. Access to unresolved classes at runtime may lead to **NoSuchClassError**.
The following classes of 'kotlin' are not resolved:
  Class kotlin.jvm.internal.Intrinsics is referenced in
    mock.plugin.internal.defaultMethod.NoInternalTypeUsageInterface.DefaultImpls.internalArgsAndPrimitiveArgs-i_VnzYk(NoInternalTypeUsageInterface $this, AnInternalType anInternalType, int i, boolean b, int ui, String[] objectArray, Integer[] intArray) : void
    mock.plugin.internal.defaultMethod.NoInternalTypeUsageInterface.DefaultImpls.internalArgsReturningInternal(NoInternalTypeUsageInterface $this, AnInternalType anInternalType, String s) : AnInternalType
    mock.plugin.internal.defaultMethod.NoInternalTypeUsageInterface.DefaultImpls.internalArgsReturningVoid(NoInternalTypeUsageInterface $this, AnInternalType anInternalType, String s) : void
  Class kotlin.jvm.internal.markers.KMappedMarker is referenced in
    mock.plugin.internal.defaultMethod.NoInternalTypeUsageInterface

*/

[bric3]

@udalov I think I understand why there's verification failure about missing kotlin package.

The mock-plugin project don't reference any Kotlin as a dependency.

intellij-plugin-verifier/intellij-plugin-verifier/verifier-test/mock-plugin/build.gradle.kts

Lines 3 to 10 in 4f92570

	dependencies {
	//compile against "before-idea", "additional-before-idea" and verify against "after-idea", "additional-after-idea"
	compileOnly(project(":verifier-test:before-idea"))
	runtimeOnly(project(":verifier-test:after-idea"))
	compileOnly(project(":verifier-test:additional-before-idea"))
	runtimeOnly(project(":verifier-test:additional-after-idea"))
	}

But since Kotlin is part of the platform should this check be skipped (as I tried here 85f2ce7) ?

Or should I add the kotlin std lib as a dependency ? Actually this doesn't work because the setup is only configured to use the jar, and not the dependencies.

intellij-plugin-verifier/intellij-plugin-verifier/verifier-test/build.gradle.kts

Lines 13 to 18 in 4f92570

	val prepareMockPlugin by tasks.registering(Copy::class) {
	dependsOn(":verifier-test:mock-plugin:build")
	into("$buildDir/mocks")
	val mockPluginBuildDir = project("mock-plugin").buildDir
	from(File(mockPluginBuildDir, "libs/mock-plugin-1.0.jar"))
	}