-
Notifications
You must be signed in to change notification settings - Fork 942
split_icon_button_olya #1497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
split_icon_button_olya #1497
Conversation
…ton_olya # Conflicts: # topics/ui/controls/icon_button.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few minor comments
|
||
## When to use | ||
|
||
The split icon button helps reduce the number of icons on the toolbar and minimize visual noise. | ||
Use the split icon button to reduce the number of actions on a toolbar if the following conditions are met: | ||
* The toolbar is horizontal. The split icon button is too wide for vertical toolbars. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one is a little bit confusing. from the previous part, I see that split icons can only be used on horizontal toolbar. from this list readers can understand that it is used either on horizontal toolbars or when one of other listed conditions is met. I'd simply remove this list item and put the info above
Use the split icon button to reduce the number of actions on a horizontal toolbar if the following conditions are met:
|
||
## When to use | ||
|
||
The split icon button helps reduce the number of icons on the toolbar and minimize visual noise. | ||
Use the split icon button to reduce the number of actions on a toolbar if the following conditions are met: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not clear: all of the following conditions should be met of one of them?
To decide whether to add the whole group of actions on the toolbar, follow the rules for the [toolbar](toolbar.md#what-items-to-add-on-toolbar). | ||
|
||
Use the split icon button on horizontal toolbars only, as it’s too wide for vertical toolbars. | ||
<note>To decide whether to add the actions to the toolbar, follow the <a href="toolbar.md#what-items-to-add-on-toolbar">Toolbar</a> guidelines.</note> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"the" is not needed here: to add actions
|
||
The main icon invokes its action on click. The triangle icon opens the action menu on click: | ||
### Add icons to all menu actions | ||
Make sure that all actions in the drop-down menu have icons. When an action is selected, its icon will be used as the main icon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an action is selected, its icon will be used as the main icon. -> When an action is selected, its icon will be shown on the toolbar.
|
||
If some actions are unavailable, the corresponding menu items are disabled. The action menu should always open, even if all the items in it are disabled. | ||
### Disable unavailable actions | ||
Do not hide the unavailable actions, show them as disabled to help users locate them in the future. The action menu should always open, even if all the items in it are disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not hide unavailable actions but show them...
|
||
If some actions are unavailable, the corresponding menu items are disabled. The action menu should always open, even if all the items in it are disabled. | ||
### Disable unavailable actions | ||
Do not hide the unavailable actions, show them as disabled to help users locate them in the future. The action menu should always open, even if all the items in it are disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
open, even if - comma is not needed here
@@ -12,48 +12,27 @@ | |||
|
|||
A split icon button appears on a horizontal toolbar and consists of two parts: the main icon and a triangle icon for the action list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a link to the Toolbar page
No description provided.