Conversation
4aaceaa to
9767912
Compare
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
sarahhaggarty
requested changes
Jan 27, 2025
Collaborator
sarahhaggarty
left a comment
There was a problem hiding this comment.
The examples are looking much better! Thanks!
I have mostly minor comments about coding style and wording. Please take a look 🙏
Co-authored-by: Sarah Haggarty <81160244+sarahhaggarty@users.noreply.github.com>
# Conflicts: # docs/topics/numbers.md
Collaborator
sarahhaggarty
left a comment
There was a problem hiding this comment.
Nice work!
Just a few minor comments for you to consider 🙏
Co-authored-by: Sarah Haggarty <81160244+sarahhaggarty@users.noreply.github.com>
Contributor
|
Bad samples fun main() {
//sampleStart
val x = 5L / 2
println (x == 2)
// Error, as Long (x) cannot be compared to Int (2)
println(x == 2L)
// true
//sampleEnd
}(3:13, 3:19) ERROR Operator '==' cannot be applied to 'kotlin.Long' and 'kotlin.Int'. |
1 similar comment
Contributor
|
Bad samples fun main() {
//sampleStart
val x = 5L / 2
println (x == 2)
// Error, as Long (x) cannot be compared to Int (2)
println(x == 2L)
// true
//sampleEnd
}(3:13, 3:19) ERROR Operator '==' cannot be applied to 'kotlin.Long' and 'kotlin.Int'. |
sarahhaggarty
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.