Skip to content

Small improvements to the Numbers page#4649

Merged
zamulla merged 13 commits intomasterfrom
better-numbers
Feb 7, 2025
Merged

Small improvements to the Numbers page#4649
zamulla merged 13 commits intomasterfrom
better-numbers

Conversation

@zamulla
Copy link
Contributor

@zamulla zamulla commented Jan 14, 2025

No description provided.

@zamulla zamulla requested a review from a team as a code owner January 14, 2025 12:42
@AlexanderPrendota

This comment was marked as outdated.

1 similar comment
@AlexanderPrendota

This comment was marked as outdated.

@AlexanderPrendota

This comment was marked as outdated.

Copy link
Collaborator

@sarahhaggarty sarahhaggarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples are looking much better! Thanks!
I have mostly minor comments about coding style and wording. Please take a look 🙏

@zamulla zamulla requested a review from sarahhaggarty January 31, 2025 14:21
Copy link
Collaborator

@sarahhaggarty sarahhaggarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
Just a few minor comments for you to consider 🙏

zamulla and others added 3 commits February 6, 2025 14:05
@AlexanderPrendota
Copy link
Contributor

Bad samples
Snippets:
File: docs/topics/numbers.md

fun main() {
//sampleStart
    val x = 5L / 2
    println (x == 2)
    // Error, as Long (x) cannot be compared to Int (2)
    
    println(x == 2L)
    // true
//sampleEnd
}

(3:13, 3:19) ERROR Operator '==' cannot be applied to 'kotlin.Long' and 'kotlin.Int'.


1 similar comment
@AlexanderPrendota
Copy link
Contributor

Bad samples
Snippets:
File: docs/topics/numbers.md

fun main() {
//sampleStart
    val x = 5L / 2
    println (x == 2)
    // Error, as Long (x) cannot be compared to Int (2)
    
    println(x == 2L)
    // true
//sampleEnd
}

(3:13, 3:19) ERROR Operator '==' cannot be applied to 'kotlin.Long' and 'kotlin.Int'.


@zamulla zamulla merged commit 847295f into master Feb 7, 2025
4 checks passed
@zamulla zamulla deleted the better-numbers branch February 7, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants