Skip to content

Adding Kobweb Kotlin/JS framework to K/JS overview page.#4651

Merged
AlejandraPedroza merged 4 commits intomasterfrom
js-add-kobweb-framework
Jan 17, 2025
Merged

Adding Kobweb Kotlin/JS framework to K/JS overview page.#4651
AlejandraPedroza merged 4 commits intomasterfrom
js-add-kobweb-framework

Conversation

@AlejandraPedroza
Copy link
Contributor

No description provided.

@AlejandraPedroza AlejandraPedroza requested a review from a team as a code owner January 14, 2025 17:27
Copy link

@bitspittle bitspittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Author of the Kobweb framework here. I hope you don't mind me butting in!

Thank you for picking this change up. I really appreciate being listed as an official framework!

I know when I originally filed the bug, I said that we were prioritizing getting the docs site done, and here we are, five months later and it's still incomplete. However, I can assure you there has been a ton of work, and it has just taken longer than expected. Things like the sidebars, navigation back and forth between articles, styling decisions, updating features we needed, and responsive layout design, stuff like that. (All while juggling incoming feature requests)

Now that that foundational work is done, we are going through the README and porting it over, and it is going fairly quickly. I'm assuming we'll have something done by end of January at this point.

I'm not sure if people want to wait for me to finish it at this point (so we could potentially include links to it from here) or if you just want to move forward ASAP with what you have now, which is fine too (although please see my two comments).

@AlejandraPedroza
Copy link
Contributor Author

Hi @bitspittle, thanks for reaching out. I've applied your suggestions, please take a look. As we are ready to promote Kobweb, let's publish it. Then, whenever the docs site is ready, we can quickly update the related links. You can tag me on the YT issue KT-70635, plus my email is alejandra.pedroza.marchena@jetbrains.com. Please let me know when it's ready, and I'll update accordingly.

Copy link

@bitspittle bitspittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I don't think you're blocked on me anyway, but this looks good 👍

Copy link
Contributor

@daniCsorbaJB daniCsorbaJB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work - LGTM 🚀

@AlejandraPedroza AlejandraPedroza merged commit f9448a7 into master Jan 17, 2025
4 checks passed
@AlejandraPedroza AlejandraPedroza deleted the js-add-kobweb-framework branch January 17, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants