-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Add extra information about ES modules inside the js-interop document #4932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: kotlin-js-doc-update
Are you sure you want to change the base?
Conversation
cb9e823
to
4789de7
Compare
@@ -33,8 +34,9 @@ Check the article on [JavaScript Modules](js-modules.md) for more information on | |||
|
|||
## Package structure | |||
|
|||
Kotlin exposes its package structure to JavaScript, so unless you define your declarations in the root package, | |||
you have to use fully qualified names in JavaScript. For example: | |||
For most of the module systems, Kotlin exposes its package structure to JavaScript, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's worth mentioning which module systems, since Kotlin supports four only (not considering PLAIN).
Plus, you say ESM is an exception, so CJS, AMD and UMD are the one with the package structure.
@@ -54,6 +56,15 @@ Or, in the case of using `plain` as a module system setting: | |||
alert(myModule.my.qualified.packagename.foo()); | |||
``` | |||
|
|||
However, there is an exception for `ES` modules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you apply my suggestion above, you could reword this one to
The ECMAScript Modules target instead loses package information, to improve the package' bundle size and to match the typical layout of ESM packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied your suggestions
…hat expose package structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. I made some minor style changes. Can you please check the new version?
No description provided.