Add extra information about ES modules inside the js-interop document #4932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlejandraPedroza
force-pushed
the
add-information-about-es-modules
branch
from
cb9e823 to
4789de7
Compare
lppedd
reviewed
Jul 24, 2025
| @@ -33,8 +34,9 @@ Check the article on [JavaScript Modules](js-modules.md) for more information on | |||
|
|
|||
| ## Package structure | |||
|
|
|||
| Kotlin exposes its package structure to JavaScript, so unless you define your declarations in the root package, | |||
| you have to use fully qualified names in JavaScript. For example: | |||
| For most of the module systems, Kotlin exposes its package structure to JavaScript, | |||
There was a problem hiding this comment.
I guess it's worth mentioning which module systems, since Kotlin supports four only (not considering PLAIN).
Plus, you say ESM is an exception, so CJS, AMD and UMD are the one with the package structure.
lppedd
reviewed
Jul 24, 2025
| @@ -54,6 +56,15 @@ Or, in the case of using `plain` as a module system setting: | |||
| alert(myModule.my.qualified.packagename.foo()); | |||
| ``` | |||
|
|
|||
| However, there is an exception for `ES` modules. | |||
There was a problem hiding this comment.
If you apply my suggestion above, you could reword this one to
The ECMAScript Modules target instead loses package information, to improve the package' bundle size and to match the typical layout of ESM packages.
…hat expose package structure
AlejandraPedroza
force-pushed
the
kotlin-js-doc-update
branch
from
30ec44c to
ae5c95d
Compare
AlejandraPedroza
added a commit
that referenced
this pull request
Aug 27, 2025
…#4932) * Add extra information about ES modules inside the js-interop document * chore: apply community suggestions on clarifying the module systems that expose package structure * update: js-interop review * chore: add links to module systems --------- Co-authored-by: alepedroza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.