-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Autotests for navbar buttons. #4982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
solarday
wants to merge
1
commit into
master
Choose a base branch
from
autotests_for_navbar
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
import { test, expect } from '@playwright/test'; | ||
|
||
test.describe('Navbar buttons', () => { | ||
test.beforeEach(async ({ page }) => { | ||
await page.goto('/'); | ||
await page.waitForSelector('button.ch2-btn.ch2-btn-primary'); | ||
await page.click('button.ch2-btn.ch2-btn-primary'); | ||
}); | ||
|
||
test('Kotlin logo opens the homepage', async ({ page }) => { | ||
const kotlinLogo = page.locator('.ktl-logo-large-module_link_AOGas'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The locators should be change to not use classes and especially classes with hashes like "_AOGas". They may change after an update, and we'll be forced to update the tests. |
||
await expect(kotlinLogo).toBeVisible(); | ||
await kotlinLogo.click(); | ||
await expect(page.url()).toContain('https://kotlinlang.org/'); | ||
}); | ||
|
||
test('Kotlin version link opens the related GitHub page', async ({ page, context }) => { | ||
const versionLink = page.locator('.ktl-logo-large-module_version-tag_k12Hw'); | ||
await expect(versionLink).toBeVisible(); | ||
const versionText = await versionLink.textContent(); | ||
console.log(`Version is: ${versionText}`); | ||
const newPagePromise = context.waitForEvent('page'); | ||
await versionLink.click(); | ||
const newPage = await newPagePromise; | ||
await newPage.waitForLoadState(); | ||
const expectedUrl = `https://github.com/JetBrains/kotlin/releases/tag/${versionText!.trim()}`; | ||
await expect(newPage.url()).toContain(expectedUrl); | ||
}); | ||
|
||
test('Solutions button is visible in navbar', async ({ page }) => { | ||
const navbar = page.locator('[data-test="header"]'); | ||
const solutionsButton = navbar.getByText('Solutions'); | ||
await expect(solutionsButton).toBeVisible(); | ||
}); | ||
|
||
test('Docs button is visible in navbar', async ({ page }) => { | ||
const navbar = page.locator('[data-test="header"]'); | ||
const docsButton = navbar.getByText('Docs'); | ||
await expect(docsButton).toBeVisible(); | ||
}); | ||
|
||
test('API button is visible in navbar', async ({ page }) => { | ||
const navbar = page.locator('[data-test="header"]'); | ||
const teachButton = navbar.getByText('API').first(); | ||
await expect(teachButton).toBeVisible(); | ||
}); | ||
|
||
test('Community button is visible in navbar', async ({ page }) => { | ||
const navbar = page.locator('[data-test="header"]'); | ||
const communityButton = navbar.getByText('Community'); | ||
await expect(communityButton).toBeVisible(); | ||
}); | ||
|
||
test('Teach button is visible in navbar', async ({ page }) => { | ||
const navbar = page.locator('[data-test="header"]'); | ||
const teachButton = navbar.getByText('Teach'); | ||
await expect(teachButton).toBeVisible(); | ||
}); | ||
|
||
test('Play button is visible in navbar', async ({ page }) => { | ||
const navbar = page.locator('[data-test="header"]'); | ||
const playButton = navbar.getByText('Play').first(); | ||
await expect(playButton).toBeVisible(); | ||
}); | ||
|
||
test('Search button is visible in navbar', async ({ page }) => { | ||
const searchButton = page.locator('[data-test="header-search-button"]'); | ||
await expect(searchButton).toBeVisible(); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest renaming the test: this part of navigation we call "header".
Also, there is a test in the master branch, api navigation. What do you think about unifying them into one file and calling it header.spec.ts? I would expect to have all the header tests related to it in one place.