minor fix for typo, indent, link, and sample code, etc #4993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiYing2010
commented
Aug 5, 2025
| @@ -100,7 +100,7 @@ You can enable all the supported ES2015 features at once by adding the `es2015` | |||
|
|
|||
| ```kotlin | |||
| tasks.withType<KotlinJsCompile>().configureEach { | |||
| kotlinOptions { | |||
| compilerOptions { | |||
There was a problem hiding this comment.
JFYI
IMO:
kotlinOptions is deprecated, should use compilerOptions instead
Comment on lines
+307
to
+312
| If you wanted to create a new class which implements the `Drawable` interface, and have the same behavior with `Circle` | ||
| class **except** for the value of the `color` property, you still need to add implementations for each member function | ||
| of the `Drawable` interface: | ||
|
|
||
| ```kotlin | ||
| class RedCircle(val circle: Circle) : Circle { | ||
|
|
||
| class RedCircle(val circle: Circle) : Drawable { |
There was a problem hiding this comment.
JFYI
IMO:
if class RedCircle extends class Circle, it will inherit all the member functions, which means there will be no necessary to implement func draw() and resize()
so I think the sample code here will confuse the readers, and I suggest to change it
| @@ -37,7 +37,7 @@ Create a project using the Kotlin Multiplatform wizard: | |||
| > | |||
| {style="note"} | |||
|
|
|||
| 2. In **composeApp** | **Tasks** | **kotlin browser**, select and run the **wasmJsBrowserDevelopmentRun** task. | |||
| 2. In **wasmdemo** | **Tasks** | **kotlin browser**, select and run the **wasmJsBrowserDevelopmentRun** task. | |||
There was a problem hiding this comment.
JFYI
the demo project name was changed to WasmDemo, but this content still use the old name composeApp
| @@ -235,7 +235,7 @@ This feature tells the compiler to apply the annotation to all relevant parts of | |||
|
|
|||
| * **`get`**: the getter method. | |||
|
|
|||
| * **`set_param`**: the parameter of the setter method, if the property is defined as `var`. | |||
| * **`setparam`**: the parameter of the setter method, if the property is defined as `var`. | |||
There was a problem hiding this comment.
IMO
I think setparam is the correct use-site target name
|
@sarahhaggarty |
daniCsorbaJB
reviewed
Aug 5, 2025
docs/topics/serialization.md
Outdated
| data class Data(val a: Int, val b: String) | ||
|
|
||
| fun main() { | ||
| val obj = Json.decodeFromString<Data>("""{"a":42, "b": "str"}""") |
There was a problem hiding this comment.
Suggested change
| val obj = Json.decodeFromString<Data>("""{"a":42, "b": "str"}""") | |
| val obj = Json.decodeFromString<Data>("""{"a":42, "b": "str"}""") |
daniCsorbaJB
reviewed
Aug 5, 2025
docs/topics/serialization.md
Outdated
| data class Data(val a: Int, val b: String) | ||
|
|
||
| fun main() { | ||
| val json = Json.encodeToString(Data(42, "str")) |
There was a problem hiding this comment.
Suggested change
| val json = Json.encodeToString(Data(42, "str")) | |
| val json = Json.encodeToString(Data(42, "str")) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change List