Conversation
sarahhaggarty
force-pushed
the
compiler-plugins
branch
from
4d55300 to
3ea8a40
Compare
zamulla
left a comment
zamulla
left a comment
There was a problem hiding this comment.
I think I get it! But I left some suggestions on clearing the whole thing up a little more.
sarahhaggarty
force-pushed
the
compiler-plugins
branch
from
3ea8a40 to
5c9dd80
Compare
sarahhaggarty
force-pushed
the
compiler-plugins
branch
from
151ffdd to
258b52b
Compare
zamulla
left a comment
zamulla
left a comment
There was a problem hiding this comment.
Two inconsequential comments on the current state — next step is for the development section to be separated from the overview.
docs/topics/compiler-plugins.md
Outdated
|
|
||
| After that, the compiler generates an Intermediate Representation (IR), which is a data structure the compiler uses as a | ||
| bridge between source code and machine code. This IR is progressively lowered into simpler forms and finally translated | ||
| into target-specific output, such as JVM bytecode, JavaScript, or native machine code. |
There was a problem hiding this comment.
I would still go for a numbered list here, to ease the matching of the blocks in the picture and comments to them. But I wouldn't go as far as saying that it would be objectively better :)
sarahhaggarty
force-pushed
the
compiler-plugins
branch
2 times, most recently
from
3d10328 to
66db97e
Compare
zamulla
left a comment
zamulla
left a comment
There was a problem hiding this comment.
Thanks! I added a couple of minor polishing suggestions to the final text, but overall I think it works well :)
| 4. Progressively lowers the IR into simpler forms. | ||
| 5. Translates the lowered IR into target-specific output, such as JVM bytecode, JavaScript, or native machine code. | ||
|
|
||
| {width=650} |
There was a problem hiding this comment.
I would put this picture below the paragraphs of "Plugins can...", for a smoother transition — it feels like the text between pictures should explain the differences between them, and right now it doesn't.
sarahhaggarty
force-pushed
the
compiler-plugins
branch
2 times, most recently
from
8f2d7a7 to
e56d11d
Compare
sarahhaggarty
force-pushed
the
compiler-plugins
branch
from
e56d11d to
9b44e9b
Compare
4 participants
This PR adds an overview of Kotlin compiler plugins and what to do if you can't find one that suits your use case.
Reviewed already by Dmitry Novozhilov and Pavel Kunyavskiy.