chore: improve production test runner on TeamCity#5350
Merged
Conversation
zoobestik
requested review from
berezinant,
krutilov and
nikpachoo
as code owners
zoobestik
force-pushed
the
e2e-tc-reporter
branch
2 times, most recently
from
5257b4f to
5630c9d
Compare
nikpachoo
approved these changes
Feb 9, 2026
solarday
reviewed
Feb 11, 2026
Contributor
There was a problem hiding this comment.
Please check how the order in which tests are run affects the closing of a cookie banner.
For example, if we run a test for a cookie banner, it should reset the previously saved state (when the banner was closed) and check that it exists. This means we'll save the state when the banner should be open.
If we then run another test where the banner should already be closed, will it pass?
zoobestik
force-pushed
the
e2e-tc-reporter
branch
2 times, most recently
from
d6d7f73 to
b43d0dc
Compare
Collaborator
Author
|
🆙 Added banner test - order independence verified What was done:
Testing approach: Tests were run in parallel with various interleavings to ensure independence:
/cc @solarday |
- Update retries, reporter, timeout, and forbidOnly logic - Introduce dynamic configuration based on the development or CI mode
- Introduced global setup script for consistent cookie banner handling in production. - Removed redundant cookie banner interaction logic from individual test files. - Updated `.gitignore` to include `test/storage-state.json`.
- Removed the unused `isStaging` function from `utils.ts`. - Replaced `isStaging` with `isProduction` in landings spec tests. - Updated test skipping logic for reverse-proxy hosts.
zoobestik
force-pushed
the
e2e-tc-reporter
branch
from
b43d0dc to
ff9926b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of huge #5333