feat(ktl-3977): added new case studies#5369
Merged
berezinant merged 8 commits intomasterfrom Feb 13, 2026
Merged
Conversation
232ea92 to
4b65823
Compare
berezinant
commented
Feb 12, 2026
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| width: 28px; | ||
| height: 28px; | ||
| } | ||
|
|
||
| /* visual compensation */ |
Contributor
Author
There was a problem hiding this comment.
not needed anymore as we updated the icon in the set
4b65823 to
7fac559
Compare
krutilov
approved these changes
Feb 12, 2026
7fac559 to
94ff5b0
Compare
berezinant
commented
Feb 13, 2026
| } | ||
| } | ||
| }; | ||
| return <MD2Markdown |
Contributor
Author
There was a problem hiding this comment.
@zoobestik I made some changes on md2html — now links have resc style. Should not be a breaking change but just in case I mentioned it
zoobestik
requested changes
Feb 13, 2026
| {item.platforms.map((platform) => | ||
| <PlatformIcon key={platform} platform={platform} /> | ||
| {item.platforms?.map((platform) => | ||
| <TechnologyIcon key={platform} type="platform" value={platform} /> |
Collaborator
There was a problem hiding this comment.
It isn't clear to me why
<TechnologyIcon type="platform" value={platform} />
<TechnologyIcon type="framework" value={framework} />is better than
<PlatformIcon key={platform} value={platform} />
<FrameworkIcon key={framework} value={framework} />?
I mean, I saw that they have shared styles, but you still add a wrapper:
{type === 'platform' ? getPlatformIcon(value) : getFrameworkIcon(value)}
You can use another way to eliminate duplication without an extra wrapper.
Contributor
Author
There was a problem hiding this comment.
Yep, the idea was not to duplicate styles. I made some changes and now it looks simpler
94ff5b0 to
97620c9
Compare
zoobestik
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.