feat(ci): run production test in CI for any branch#5395
Merged
Conversation
zoobestik
requested review from
berezinant,
krutilov and
nikpachoo
as code owners
nikpachoo
reviewed
Feb 25, 2026
| await expect(getStartedButton).toBeVisible(); | ||
| await getStartedButton.click(); | ||
| await expect(page.url()).toContain('/docs/getting-started.html'); | ||
| expect(page.url()).toContain(`${baseURL}/docs/getting-started.html`); |
Collaborator
There was a problem hiding this comment.
Why do we need to use baseURL in the checks?
Collaborator
Author
There was a problem hiding this comment.
Be honest, no. But to me it looks safer with this prefix.
I mean, AFAIK, .toContain works exactly like .includes. With baseURL it guarantees that you don't use certain domains in a URL like https://staging.kotlinlang.org/docs/getting-started.html or any other wrong domain (misspelled) one will fail, while .toContain('/docs/getting-started.html') passes as success.
nikpachoo
approved these changes
Feb 25, 2026
- Remove unused Dockerfiles for E2E, nginx, and Playwright environments. - Simplify `docker-compose-e2e-statics.yml` configuration. - Refactor TeamCity configuration to use shared `E2ERunner`. - Standardize E2E test command and dependencies in `package.json`.
- Remove deprecated scripts for E2E tests (`run.sh`, `run-e2e.sh`, `stop.sh`, `up.sh`, `wait-for-endpoint.sh`). - Update TeamCity `E2ETests.kt` to reference simplified script path (`run-e2e-tests.sh`).
- Replace `stepE2ETest` with inline script steps in `E2EProductionTest.kt` and `E2ETests.kt`. - Remove deprecated `stepE2ETest` method and associated constants from `E2ERunner.kt`. - Update E2E test script to run directly in TeamCity configurations.
- Refactor URL assertions in `main-page-buttons.spec.ts` and `solutions-tab.spec.ts` to dynamically use `${baseURL}`.
- Ensure consistency across tests with `baseURL` and remove hardcoded URLs where applicable.
- Add `isProduction` usage in `footer-kotlin-ecosystem-buttons.spec.ts` to conditionally verify Opt-Out popup only in production. - Fix imports formatting and adjust parameters for consistent test structure. - Correct indentation in test blocks for better readability.
zoobestik
force-pushed
the
playground/e2e-local
branch
from
752a4d4 to
83a721f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This is step 2 for #5333. In this PR, changes run "production" tests on CI without deploying it to production:
See screenshots:
for nextjs localhost
for any branch on CI
Keep working fo Production
Changes
docker-compose-e2e-statics.ymlis enough.