Merged
Conversation
nikpachoo
approved these changes
Mar 13, 2026
nikpachoo
reviewed
Mar 13, 2026
| topMenuHomeUrl={MULTIPLATFORM_URL} | ||
| topMenuItems={MULTIPLATFORM_TOP_MENU_ITEMS} | ||
| topMenuButton={<Button href={MULTIPLATFORM_GET_STARTED_URL}>Get started</Button>} | ||
| canonical={`https://kotlinlang.org/case-studies/${frontmatter.slug}/`} |
Collaborator
There was a problem hiding this comment.
Just in case, have you fetched the last changes in the templates? I'd expect my last changes regarding the canonical would let the canonical appear in case-studies as well
Contributor
Author
There was a problem hiding this comment.
@nikpachoo yes, I've checked, but there is a case with dynamic routes that needed to be handled additionaly.
Now for separate case study page I get <link rel="canonical" href="https://kotlinlang.org/case-studies/[id]/"> instead of correct canonical
5c62a57 to
c527d89
Compare
8443dee to
e791ee1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.