fix(KTL-4236): Grammar: Links to documentation were broken#5439
Merged
fix(KTL-4236): Grammar: Links to documentation were broken#5439
Conversation
zoobestik
force-pushed
the
ktl-4236-gammar-links
branch
2 times, most recently
from
889d738 to
4f91122
Compare
zoobestik
requested review from
berezinant,
krutilov and
nikpachoo
as code owners
nikpachoo
reviewed
Mar 16, 2026
- Implement comprehensive end-to-end tests for the grammar page verifying redirects, content rendering, navigation, and link behavior. - Add grammar page-specific test suite to `test:ci` script in `package.json`.
zoobestik
force-pushed
the
ktl-4236-gammar-links
branch
from
4f91122 to
ae4f570
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix:
rebaseRelativeUrlfunction inblocks/grammar/markdown.tsxnow correctly handles anchor links (starting with#), returning them as-is instead of incorrectly rebasing them.Markdowncomponent inutils/mdToHtml.tsxwas fixed to ensure custom class names are applied correctly.Tests:
test/e2e/grammar/page.tsandtest/production/grammar.spec.tscc @solarday