[Commonizer] Rewrite InlineSourceBuilder into FIR test infrastructure

Also, adjust two tests: apparently, K1 analysis and metadata serialization
were also producing redundant empty packages.

`// hasStableParameterNames=false` is used, for example, in
`FunctionCommonizationFromSourcesTest#testValueParameters`.

^KT-74769

Author: lunakoly

compiler/cli/src/org/jetbrains/kotlin/cli/common/CLICompiler.kt

@@ -37,14 +37,12 @@ import org.jetbrains.kotlin.compiler.plugin.ComponentRegistrar
 import org.jetbrains.kotlin.config.*
 import org.jetbrains.kotlin.metadata.deserialization.BinaryVersion
 import org.jetbrains.kotlin.platform.TargetPlatform
-import org.jetbrains.kotlin.platform.isCommon
 import org.jetbrains.kotlin.progress.CompilationCanceledException
 import org.jetbrains.kotlin.progress.CompilationCanceledStatus
 import org.jetbrains.kotlin.progress.IncrementalNextRoundException
 import org.jetbrains.kotlin.progress.ProgressIndicatorAndCompilationCanceledStatus
 import org.jetbrains.kotlin.util.CompilerType
 import org.jetbrains.kotlin.util.PerformanceManager
-import org.jetbrains.kotlin.util.PerformanceManagerImpl
 import org.jetbrains.kotlin.util.forEachStringMeasurement
 import org.jetbrains.kotlin.utils.KotlinPaths
 import org.jetbrains.kotlin.utils.PathUtil
@@ -59,7 +57,7 @@ abstract class CLICompiler<A : CommonCompilerArguments> {
     abstract val platform: TargetPlatform
 
     open val defaultPerformanceManager: PerformanceManager by lazy {
-        PerformanceManagerImpl(platform, "Kotlin to ${if (platform.isCommon()) "Metadata" else platform.first().platformName} compiler")
+        createPerformanceManagerFor(platform)
     }
 
     var isReadingSettingsFromEnvironmentAllowed: Boolean =

compiler/cli/src/org/jetbrains/kotlin/cli/common/utils.kt

@@ -31,9 +31,12 @@ import org.jetbrains.kotlin.fir.declarations.FirFile
 import org.jetbrains.kotlin.fir.packageFqName
 import org.jetbrains.kotlin.name.FqName
 import org.jetbrains.kotlin.name.isSubpackageOf
+import org.jetbrains.kotlin.platform.TargetPlatform
+import org.jetbrains.kotlin.platform.isCommon
 import org.jetbrains.kotlin.psi.KtFile
 import org.jetbrains.kotlin.text
 import org.jetbrains.kotlin.util.Logger
+import org.jetbrains.kotlin.util.PerformanceManagerImpl
 import java.io.File
 import org.jetbrains.kotlin.cli.common.messages.toLogger as toLoggerNew
 
@@ -129,6 +132,9 @@ fun <PathProvider : Any> getLibraryFromHome(
     return null
 }
 
+fun createPerformanceManagerFor(platform: TargetPlatform) =
+    PerformanceManagerImpl(platform, "Kotlin to ${if (platform.isCommon()) "Metadata" else platform.first().platformName} compiler")
+
 @Deprecated(
     "Use org.jetbrains.kotlin.cli.common.messages.toLogger() instead",
     ReplaceWith("toLogger()", "org.jetbrains.kotlin.cli.common.messages.toLogger"),

compiler/cli/src/org/jetbrains/kotlin/cli/pipeline/metadata/MetadataCliPipeline.kt

@@ -10,7 +10,6 @@ import org.jetbrains.kotlin.cli.common.arguments.K2MetadataCompilerArguments
 import org.jetbrains.kotlin.cli.pipeline.AbstractCliPipeline
 import org.jetbrains.kotlin.cli.pipeline.ArgumentsPipelineArtifact
 import org.jetbrains.kotlin.cli.pipeline.PipelineContext
-import org.jetbrains.kotlin.cli.pipeline.PipelinePhase
 import org.jetbrains.kotlin.config.phaser.CompilerPhase
 import org.jetbrains.kotlin.util.PerformanceManager
 
@@ -23,8 +22,8 @@ class MetadataCliPipeline(override val defaultPerformanceManager: PerformanceMan
 
     private fun serializerPhase(
         arguments: K2MetadataCompilerArguments
-    ): PipelinePhase<MetadataFrontendPipelineArtifact, MetadataSerializationArtifact> = when {
+    ): CompilerPhase<PipelineContext, MetadataFrontendPipelineArtifact, MetadataSerializationArtifact> = when {
         arguments.legacyMetadataJar -> MetadataLegacySerializerPhase
-        else -> MetadataKlibSerializerPhase
+        else -> MetadataKlibInMemorySerializerPhase then MetadataKlibFileWriterPhase
     }
 }

compiler/cli/src/org/jetbrains/kotlin/cli/pipeline/metadata/MetadataKlibSerializerPhase.kt

@@ -20,16 +20,14 @@ import org.jetbrains.kotlin.library.SerializedMetadata
 import org.jetbrains.kotlin.library.metadata.KlibMetadataHeaderFlags
 import org.jetbrains.kotlin.library.metadata.KlibMetadataProtoBuf
 
-object MetadataKlibSerializerPhase : PipelinePhase<MetadataFrontendPipelineArtifact, MetadataSerializationArtifact>(
-    name = "MetadataKlibSerializerPhase",
+object MetadataKlibInMemorySerializerPhase : PipelinePhase<MetadataFrontendPipelineArtifact, MetadataInMemorySerializationArtifact>(
+    name = "MetadataKlibInMemorySerializerPhase",
     preActions = setOf(PerformanceNotifications.KlibWritingStarted),
     postActions = setOf(PerformanceNotifications.KlibWritingFinished, CheckCompilationErrors.CheckDiagnosticCollector)
 ) {
-    override fun executePhase(input: MetadataFrontendPipelineArtifact): MetadataSerializationArtifact {
+    override fun executePhase(input: MetadataFrontendPipelineArtifact): MetadataInMemorySerializationArtifact {
         val (firResult, configuration, _, _) = input
         val metadataVersion = input.metadataVersion
-        val destDir = configuration.metadataDestinationDirectory!!
-
         val fragments = mutableMapOf<String, MutableList<ByteArray>>()
 
         val analysisResult = firResult.outputs
@@ -71,15 +69,24 @@ object MetadataKlibSerializerPhase : PipelinePhase<MetadataFrontendPipelineArtif
         }
 
         val module = header.build().toByteArray()
-
         val serializedMetadata = SerializedMetadata(module, fragmentParts, fragmentNames)
+        return MetadataInMemorySerializationArtifact(serializedMetadata, configuration)
+    }
+}
 
-        buildKotlinMetadataLibrary(configuration, serializedMetadata, destDir)
+object MetadataKlibFileWriterPhase : PipelinePhase<MetadataInMemorySerializationArtifact, MetadataSerializationArtifact>(
+    name = "MetadataKlibFileWriterPhase",
+    preActions = setOf(PerformanceNotifications.KlibWritingStarted),
+    postActions = setOf(PerformanceNotifications.KlibWritingFinished, CheckCompilationErrors.CheckDiagnosticCollector)
+) {
+    override fun executePhase(input: MetadataInMemorySerializationArtifact): MetadataSerializationArtifact {
+        val destDir = input.configuration.metadataDestinationDirectory!!
+        buildKotlinMetadataLibrary(input.configuration, input.metadata, destDir)
 
         return MetadataSerializationArtifact(
             outputInfo = null,
-            configuration,
-            destDir.canonicalPath
+            input.configuration,
+            destDir.canonicalPath,
         )
     }
 }

compiler/cli/src/org/jetbrains/kotlin/cli/pipeline/metadata/MetadataPipelineArtifacts.kt

@@ -13,6 +13,7 @@ import org.jetbrains.kotlin.config.CompilerConfiguration
 import org.jetbrains.kotlin.config.metadataVersion
 import org.jetbrains.kotlin.diagnostics.impl.BaseDiagnosticsCollector
 import org.jetbrains.kotlin.fir.pipeline.FirResult
+import org.jetbrains.kotlin.library.SerializedMetadata
 import org.jetbrains.kotlin.metadata.builtins.BuiltInsBinaryVersion
 
 data class MetadataFrontendPipelineArtifact(
@@ -26,6 +27,11 @@ data class MetadataFrontendPipelineArtifact(
         copy(diagnosticCollector = newDiagnosticsCollector)
 }
 
+data class MetadataInMemorySerializationArtifact(
+    val metadata: SerializedMetadata,
+    val configuration: CompilerConfiguration,
+) : PipelineArtifact()
+
 data class MetadataSerializationArtifact(
     val outputInfo: OutputInfo?,
     val configuration: CompilerConfiguration,

compiler/tests-common-new/testFixtures/org/jetbrains/kotlin/test/frontend/fir/FirCliMetadataFrontendFacade.kt

@@ -7,7 +7,8 @@ package org.jetbrains.kotlin.test.frontend.fir
 
 import org.jetbrains.kotlin.cli.pipeline.metadata.MetadataFrontendPipelineArtifact
 import org.jetbrains.kotlin.cli.pipeline.metadata.MetadataFrontendPipelinePhase
-import org.jetbrains.kotlin.cli.pipeline.metadata.MetadataKlibSerializerPhase
+import org.jetbrains.kotlin.cli.pipeline.metadata.MetadataKlibFileWriterPhase
+import org.jetbrains.kotlin.cli.pipeline.metadata.MetadataKlibInMemorySerializerPhase
 import org.jetbrains.kotlin.config.LanguageFeature
 import org.jetbrains.kotlin.diagnostics.impl.BaseDiagnosticsCollector
 import org.jetbrains.kotlin.diagnostics.impl.SimpleDiagnosticsCollector
@@ -61,7 +62,7 @@ class FirCliMetadataSerializerFacade(val testServices: TestServices) : AbstractT
             "Incompatible type of input artifact: expected ${MetadataFrontendPipelineArtifact::class}, actual ${inputArtifact.cliArtifact::class}"
         }
         val input = inputArtifact.cliArtifact
-        val output = MetadataKlibSerializerPhase.executePhase(input)
+        val output = MetadataKlibInMemorySerializerPhase.executePhase(input).let(MetadataKlibFileWriterPhase::executePhase)
         return BinaryArtifacts.KLib(
             File(output.destination),
             SimpleDiagnosticsCollector(BaseDiagnosticsCollector.RawReporter.DO_NOTHING)

native/commonizer/build.gradle.kts

@@ -1,3 +1,5 @@
+import org.jetbrains.kotlin.gradle.utils.NativeCompilerDownloader
+
 plugins {
     kotlin("jvm")
     id("project-tests-convention")
@@ -68,3 +70,17 @@ projectTests {
 runtimeJar()
 sourcesJar { includeEmptyDirs = false; eachFile { exclude() } } // empty Jar, no public sources
 javadocJar { includeEmptyDirs = false; eachFile { exclude() } } // empty Jar, no public javadocs
+
+tasks.test.configure {
+    // Use the bootstrap K/N stdlib for compiling test code samples.
+    val nativeDistributionDownloader = NativeCompilerDownloader(project).also { it.downloadIfNeeded() }
+
+    jvmArgumentProviders += objects.newInstance<SystemPropertyClasspathProvider>().apply {
+        val compilerDirectory = project.layout.dir(
+            providers.provider { nativeDistributionDownloader.compilerDirectory }
+        )
+
+        classpath.from(compilerDirectory)
+        property.set("kotlin.internal.native.test.nativeHome")
+    }
+}