Skip to content

fix kotlin native windows commandline encoding #5511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+28 −0
Open

fix kotlin native windows commandline encoding #5511

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5286d3
fix kotlin native windows commandline encoding
iseki0 Sep 29, 2025
d11f248
fix kotlin native windows commandline encoding
iseki0 Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions kotlin-native/runtime/src/launcher/cpp/launcher.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@
#include "KString.h"
#include "Types.h"
#include "Worker.h"
#ifdef KONAN_WINDOWS
#include <windows.h>
#endif

#include "launcher.h"

Expand All @@ -47,10 +50,35 @@ OBJ_GETTER(setupArgs, int argc, const char** argv) {
return result;
}

#ifdef KONAN_WINDOWS
// On Windows, we should use Windows API to avoid encoding issues.
OBJ_GETTER(setupArgsWindows) {
LPWSTR cmdline = GetCommandLineW();
RuntimeCheck(cmdline != nullptr, "GetCommandLineW() returned null");
int wargc;
LPWSTR* wargv = CommandLineToArgvW(cmdline, &wargc);
// The count is one less, because we skip argv[0] which is the binary name.
ObjHeader* result = AllocArrayInstance(theArrayTypeInfo, std::max(0, wargc - 1), OBJ_RESULT);
ArrayHeader* array = result->array();
for (int index = 1; index < wargc - 1; index++) {
ObjHolder result;
CreateStringFromUtf16(wargv[index], result.slot());
UpdateHeapRef(ArrayAddressOfElementAt(array, index - 1), result.obj());
}
LocalFree(wargv);
return result;
}
#endif

//--- main --------------------------------------------------------------------//
extern "C" KInt Konan_run_start(int argc, const char** argv) {
ObjHolder args;
#ifdef KONAN_WINDOWS
setupArgsWindows(args.slot());
#else
setupArgs(argc, argv, args.slot());
#endif

return Konan_start(args.obj());
}

Expand Down