Create BaseKonanSymbols to reduce symbols for Fir2IR phase #5600

aviroop-123 · 2025-12-15T21:12:21Z

https://youtrack.jetbrains.com/issue/KT-83129

ivandev0

Let's make it slightly different. Please move all these required symbols into PreSerializationNativeSymbols and implement them in PreSerializationNativeSymbols.Impl. You can copy/cut required class and callable ids from KonanSymbols. If something is missing (like InteropFqNames) you can add them in NativeStandardInteropNames (with an additional dependency on :core:compiler.common.native insode ir:backend.common). Maybe there is a better approach than copy paste, but it is better to be commented by someone from the Native team (cc @SvyatoslavScherbina )

SvyatoslavScherbina · 2025-12-16T17:12:31Z

Maybe there is a better approach than copy paste, but it is better to be commented by someone from the Native team (cc @SvyatoslavScherbina )

Copying is fine with me. Anyway, I need to take a look at what values will need to be copied first to have a real opinion.

ivandev0

The change is correct. Just some minor comments.

compiler/cli/cli-native-klib/src/main/kotlin/org/jetbrains/kotlin/native/Fir2Ir.kt

...iler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/ir/PreSerializationSymbols.kt

compiler/ir/backend.native/src/org/jetbrains/kotlin/backend/konan/ir/Ir.kt

core/compiler.common.native/src/org/jetbrains/kotlin/name/NativeStandardInteropNames.kt

ivandev0

Everything is fine from my side

ivandev0 · 2026-01-14T15:12:43Z

Please take a look at NativePreSerializationSymbolsTest. Because you moved some symbols to the first stage, you should mark them with special annotations. Please run the test and follow the instructions from the output.

Also, please, rebase your branch on top of fresh master.

aviroop-123 · 2026-01-16T20:25:59Z

Please take a look at NativePreSerializationSymbolsTest. Because you moved some symbols to the first stage, you should mark them with special annotations. Please run the test and follow the instructions from the output.

Also, please, rebase your branch on top of fresh master.

Done!

fzhinkin · 2026-01-16T21:48:39Z

kotlin-native/runtime/src/main/kotlin/kotlin/native/internal/RuntimeUtils.kt

 import kotlin.native.internal.ref.releaseExternalRCRef

 @ExportForCppRuntime
+@PublishedApi


Has anything changed in terms of where these symbols can be used (and when corresponding function calls are now emitted)?

Note that this change requires updating the ABI dump for the native stdlib, but I don't really understand why these symbols are public now.

As Ivan said, I followed the instructions for fixing the NativePreSerializationTest and this change was suggested in the error logs, and it fixed the test.

@ivandev0 Shouldn't it be @UsedFromCompilerGeneratedCode instead of @PublishedApi?

Shouldn't it be @UsedFromCompilerGeneratedCode instead of @PublishedApi?

It is already marked as UsedFromCompilerGeneratedCode, but now we say that this symbol is used on the first compilation stage and so by our rules it requires PublishedApi

Has anything changed in terms of where these symbols can be used (and when corresponding function calls are now emitted)?

No, everything is the same. We just formalized how these symbols can be used.

There will be a change with a new inline mode enabled for klib backends (when inliner works before serialization). We will start to write these symbols into klibs and so all the internal declarations must be marked with PublishedApi.

I would prefer these symbols not to become public. Please explore alternatives.

I see that these symbols are not actually used to create new declarations (at least for the compilation phase before serialization). I think we can simplify some things. Let me check it for a bit and I will come back with a plan.

@ivandev0 Did you figure out something or should I proceed with the current changes?

@aviroop-123 Yes, I am working on a fix that will simplify things for you. Please wait a little bit.

ivandev0

Please squash all the changes and edit the commit message to reflect the change properly. Also, please rebase on the latest green master (without it I can't run CI to fully check your changes).

^KT-83129

aviroop-123 · 2026-01-19T21:43:32Z

Please squash all the changes and edit the commit message to reflect the change properly. Also, please rebase on the latest green master (without it I can't run CI to fully check your changes).

Done!

ivandev0

Please run org.jetbrains.kotlin.tools.tests.KlibPublicAPITest and fix the falling nativeStdlib test.
Rebase on master once again because I see that there are conflicts in your branch.
Please change the commit message. It does not reflect that was actually changed (we did not create BaseKonanSymbols).

ivandev0 · 2026-01-29T16:28:42Z

@aviroop-123 I pushed the necessary preparation commits. Please take a look at 767551b. After this commit you don't need createUninitializedInstance, createUninitializedArray, createEmptyString, reinterpret and initInstance symbols on the first stage. Please remove them from PreSerializationNativeSymbols and move back to BackendNativeSymbols.

Also, I didn't find any reasons to move throwNullPointerException. If it is not used, please also move it back with the corresponding change in stdlib files.

ivandev0 · 2026-02-10T15:03:38Z

@aviroop-123 Closing this PR. I fixed the issue in this commit

aviroop-123 requested review from a team as code owners December 15, 2025 21:12

aviroop-123 requested review from SvyatoslavScherbina, dzharkov and mpiekutowski December 15, 2025 21:12

mpiekutowski requested review from ddolovov and removed request for mpiekutowski December 15, 2025 22:57

ddolovov requested a review from ivandev0 December 16, 2025 09:58

ivandev0 requested changes Dec 16, 2025

View reviewed changes

aviroop-123 requested review from a team as code owners December 21, 2025 15:32

aviroop-123 requested review from AnzhelaSukhanova, alex28sh, goodwinnk and grechkovlad December 21, 2025 15:32

aviroop-123 force-pushed the minimize-konan-symbols branch from 5d8d941 to 7120e87 Compare December 22, 2025 19:50

aviroop-123 requested a review from ivandev0 December 22, 2025 19:52

ivandev0 requested changes Jan 9, 2026

View reviewed changes

aviroop-123 requested a review from ivandev0 January 12, 2026 20:36

ivandev0 previously approved these changes Jan 13, 2026

View reviewed changes

SvyatoslavScherbina previously approved these changes Jan 14, 2026

View reviewed changes

ivandev0 self-requested a review January 14, 2026 15:12

demiurg906 assigned ivandev0 Jan 15, 2026

aviroop-123 dismissed stale reviews from SvyatoslavScherbina and ivandev0 via 6f9f8b5 January 16, 2026 20:14

aviroop-123 force-pushed the minimize-konan-symbols branch from d118394 to 6f9f8b5 Compare January 16, 2026 20:14

aviroop-123 requested review from DmitryNekrasov, fzhinkin, ilya-g and qwwdfsad as code owners January 16, 2026 20:14

fzhinkin reviewed Jan 16, 2026

View reviewed changes

ivandev0 requested changes Jan 19, 2026

View reviewed changes

aviroop-123 force-pushed the minimize-konan-symbols branch from 6f9f8b5 to 5200439 Compare January 19, 2026 21:27

Create BaseKonanSymbols to reduce symbols for Fir2IR phase.

f1884ae

^KT-83129

aviroop-123 force-pushed the minimize-konan-symbols branch from 5200439 to f1884ae Compare January 19, 2026 21:42

ivandev0 requested changes Jan 20, 2026

View reviewed changes

ivandev0 closed this Feb 10, 2026

Create BaseKonanSymbols to reduce symbols for Fir2IR phase #5600

Create BaseKonanSymbols to reduce symbols for Fir2IR phase #5600

Conversation

aviroop-123 commented Dec 15, 2025

Uh oh!

ivandev0 left a comment

Choose a reason for hiding this comment

Uh oh!

SvyatoslavScherbina commented Dec 16, 2025

Uh oh!

ivandev0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ivandev0 left a comment

Choose a reason for hiding this comment

Uh oh!

ivandev0 commented Jan 14, 2026

Uh oh!

aviroop-123 commented Jan 16, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ivandev0 left a comment

Choose a reason for hiding this comment

Uh oh!

aviroop-123 commented Jan 19, 2026

Uh oh!

ivandev0 left a comment

Choose a reason for hiding this comment

Uh oh!

ivandev0 commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ivandev0 commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ivandev0 commented Jan 29, 2026 •

edited

Loading