Skip to content

Conversation

@VincentLanglet
Copy link
Contributor Author

How do I avoid the test failure @isfedorov @LolGleb ?

Because as you can see in php-src there is a different return type in phpdoc and native type
with a // TODO return type should be static.

@LolGleb
Copy link
Contributor

LolGleb commented Aug 19, 2025

Hi, thanks for the PR. As far as I can tell, your changes look good. We'll need some time on our end to figure out how to adapt the tests, which will take a while.

If you'd like to help with that, we'd be super grateful, but just a heads-up, framework is quite complex

@isfedorov isfedorov merged commit 68b2f32 into JetBrains:master Sep 2, 2025
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants