Skip to content

Enhance BcMath\Number class with types and exceptions #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enhance BcMath\Number class with types and exceptions #1800

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1ea220
Enhance BcMath\Number class with types and exceptions
AJenbo Oct 3, 2025
286e2f9
Remove return type hint from __toString method
AJenbo Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 43 additions & 1 deletion bcmath/bcmath.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,28 +275,64 @@ function bcdivmod(string $num1, string $num2, ?int $scale = null): array {}
*/
final readonly class Number implements \Stringable
{
/** @var numeric-string */
public readonly string $value;
public readonly int $scale;

/** @param int|numeric-string $num */
public function __construct(string|int $num) {}

/**
* @param Number|int|numeric-string $num
* @throws \DivisionByZeroError
*/
public function add(Number|string|int $num, ?int $scale = null): Number {}

/**
* @param Number|int|numeric-string $num
* @throws \DivisionByZeroError
*/
public function sub(Number|string|int $num, ?int $scale = null): Number {}

/**
* @param Number|int|numeric-string $num
* @throws \DivisionByZeroError
*/
public function mul(Number|string|int $num, ?int $scale = null): Number {}

/**
* @param Number|int|numeric-string $num
* @throws \DivisionByZeroError
*/
public function div(Number|string|int $num, ?int $scale = null): Number {}

/**
* @param Number|int|numeric-string $num
* @throws \DivisionByZeroError
*/
public function mod(Number|string|int $num, ?int $scale = null): Number {}

/** @return Number[] */
/**
* @param Number|int|numeric-string $num
* @return Number[]
* @throws \DivisionByZeroError
*/
public function divmod(Number|string|int $num, ?int $scale = null): array {}

/**
* @param Number|int|numeric-string $exponent
* @param Number|int|numeric-string $modulus
* @throws \DivisionByZeroError
*/
public function powmod(Number|string|int $exponent, Number|string|int $modulus, ?int $scale = null): Number {}

/**
* @param Number|int|numeric-string $exponent
* @throws \DivisionByZeroError
*/
public function pow(Number|string|int $exponent, ?int $scale = null): Number {}

/** @throws \ValueError */
public function sqrt(?int $scale = null): Number {}

public function floor(): Number {}
Expand All @@ -305,12 +341,18 @@ public function ceil(): Number {}

public function round(int $precision = 0, \RoundingMode $mode = \RoundingMode::HalfAwayFromZero): Number {}

/**
* @param Number|int|numeric-string $num
* @return int Returns -1, 0, or 1
*/
public function compare(Number|string|int $num, ?int $scale = null): int {}

public function __toString(): string {}

/** @return array{value:numeric-string} */
public function __serialize(): array {}

/** @param array{value:numeric-string} $data */
public function __unserialize(array $data): void {}
}
}
Loading