Skip to content

Generalize missing records fix further and add tests #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: net203
Choose a base branch
from
Open

Generalize missing records fix further and add tests #158

wants to merge 4 commits into from

Conversation

mcon
Copy link
Contributor

@mcon mcon commented Aug 1, 2020

Let me know if there are more testcases you'd like for this particular change.

auduchinok
auduchinok reviewed Aug 4, 2020
View reviewed changes
Copy link
Member

@auduchinok auduchinok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just commenting the dotsettings changes, will do a proper review separately.

@mcon mcon changed the base branch from net202 to net203 November 14, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auduchinok auduchinok auduchinok left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcon @auduchinok