Conversation
script/build.py
Outdated
| 'skia_use_system_icu=false', | ||
| 'skia_enable_skottie=true' | ||
| 'skia_enable_skottie=true', | ||
| 'skia_use_egl=true' |
There was a problem hiding this comment.
I am not sure if this has any side effects for other platforms. Alternatively, I could enable it only for Linux arm64.
I expect that enabling it for all platforms would just increase the binary size.
I think it's better to enable it only for the targets where it's required right now.
There was a problem hiding this comment.
@eymar Alright, now it is enabled only for linuxArm64 target where it is needed.
|
Hey @eymar, I rebased the PR on main. Could you please check if that resolves the build issues by triggering the workflow? |
|
@eymar I triggered a run on my fork and it shows no issues: https://github.com/Thomas-Vos/skia-pack/actions/runs/17074207122 |
|
Approved CI run (Oleksandr is on vacation) |
|
Could this be merged? |
|
@Thomas-Vos thanks for a ping :) I got back only this Monday. LGTM! thanks |
|
@eymar Great, thanks! Hope you had a great holiday. When there is a new skia-pack release I will fix the EGL PR for Skiko. |
|
Hi @eymar, could you please publish a new Skia-pack version so I can get the EGL tests up and running in Skiko? JetBrains/skiko#1052 |
|
@Thomas-Vos it was supposed to be published by CI trigger after this merge. It failed because the version already exists. Fixed in #75 Ideally, this shouldn't be a manual process of course 🙈 |
Requires skia-pack version update before merging: JetBrains/skia-pack#68 Required for my linuxArm64 device which only support EGL. https://youtrack.jetbrains.com/issue/SKIKO-918
3 participants
Required for my linuxArm64 device which only support EGL.
https://youtrack.jetbrains.com/issue/SKIKO-918
I am not sure if this has any side effects for other platforms. Alternatively, I could enable it only for Linux arm64.