minor note about matchFamilyStyle that doesn't work#698
Open
SergeevPavel wants to merge 2 commits intomasterfrom
Open
minor note about matchFamilyStyle that doesn't work#698SergeevPavel wants to merge 2 commits intomasterfrom
matchFamilyStyle that doesn't work#698SergeevPavel wants to merge 2 commits intomasterfrom
Conversation
MatkovIvan
reviewed
May 4, 2023
| when `TypefaceFontProvider` is used | ||
| `matchFamilyStyle` always returns null, | ||
| even if we have an appropriate styles in styleSet returned by `matchFamily` | ||
| It should be fixed in skia at some point |
Contributor
There was a problem hiding this comment.
Let's add TODO mark here
MatkovIvan
reviewed
May 4, 2023
|
|
||
| constructor(weight: Int, width: Int, slant: FontSlant) { | ||
| _value = weight and 65535 or (width and 255 shl 16) or (slant.ordinal shl 24) | ||
| _value = (weight and 0xFFFF) or |
Contributor
There was a problem hiding this comment.
Can we add require or similar thing to print readable message in case of overflow?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.