TestOccurence.details is now fetched only in fullBean#64
Open
zabbius wants to merge 3 commits intoJetBrains:masterfrom
Open
TestOccurence.details is now fetched only in fullBean#64zabbius wants to merge 3 commits intoJetBrains:masterfrom
zabbius wants to merge 3 commits intoJetBrains:masterfrom
Conversation
chashnikov
reviewed
May 20, 2019
|
|
||
| @Deprecated(message = "Deprecated due to unclear naming. use TestRun class", replaceWith = ReplaceWith("TestRun")) | ||
| interface TestOccurrence { | ||
| val id : TestOccurenceId |
Member
There was a problem hiding this comment.
Why do you add a property to a deprecated class? And add a new class which names is derived from name which is described as unclear in the comment?
Contributor
|
@zabbius What's the status? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.