Skip to content

Fix CI Error in OpenJij#447

Merged
j-i-k-o merged 13 commits intomainfrom
hotfix/fix-geninfo-error
Feb 27, 2025
Merged

Fix CI Error in OpenJij#447
j-i-k-o merged 13 commits intomainfrom
hotfix/fix-geninfo-error

Conversation

@j-i-k-o
Copy link
Collaborator

@j-i-k-o j-i-k-o commented Feb 26, 2025

Changes

  • Fix geninfo line number mismatch error

    • We fixed a CI error that's occurring during the code coverage data collection step for the C++ tests. The error is happening with the geninfo tool and indicates a line number mismatch in the C++ hpp file.
    • This appears to be a bug of gcc 14 as indicated in the issue lcov fails with gcc 14 linux-test-project/lcov#296. Since GitHub Actions set the ubuntu-latest to ubuntu-24.04, the default compiler is replaced with gcc 14.
    • We fixed the error by adding --ignore-errors mismatch to geninfo.
    • The following process using gcov is temporarily skipped.
  • Modify setup.cfg and test command

    • modify setup.cfg by replacing tests_require with extras_require.
    • replace python setup.py test to pytest.

Related issue

@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.34%. Comparing base (1ebe26c) to head (ccaff63).
Report is 21 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
- Coverage   74.09%   69.34%   -4.76%     
==========================================
  Files          42       42              
  Lines        2567     2567              
  Branches      925      897      -28     
==========================================
- Hits         1902     1780     -122     
- Misses        379      502     +123     
+ Partials      286      285       -1     
Flag Coverage Δ
openjij 70.48% <ø> (+3.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

@j-i-k-o j-i-k-o changed the title Fix geninfo line number mismatch error by adding --ignore-errors mism… Fix CI Error in OpenJij Feb 27, 2025
@j-i-k-o j-i-k-o requested a review from 29rou February 27, 2025 01:44
@j-i-k-o j-i-k-o marked this pull request as ready for review February 27, 2025 01:44
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit ccaff63 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.0%.

View more on Code Climate.

@j-i-k-o j-i-k-o merged commit a1c580a into main Feb 27, 2025
25 checks passed
@j-i-k-o j-i-k-o deleted the hotfix/fix-geninfo-error branch February 27, 2025 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants