Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the SciPy dependency from OpenJij, enabling the installation of NumPy 2.x series, and fixes a macOS build issue with libomp detection.
- Removed SciPy dependency from package requirements
- Updated test code to use NumPy arrays directly instead of SciPy sparse matrices
- Fixed CMake libomp detection logic on macOS to properly check if libomp is installed before attempting to use it
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| setup.cfg | Removed scipy dependency from install_requires |
| tests/test_cxx.py | Replaced scipy.sparse usage with direct NumPy arrays and removed scipy import |
| CMakeLists.txt | Fixed libomp detection logic to check installation before getting prefix path |
29rou
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
pip install .ができることを確認しました。