Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the Suwa-Todo algorithm implementation where overflow avoidance by scaling probabilities was not properly considered. The fix adjusts the probability calculation to account for the weight scaling factor.
- Modifies random number generation to scale by current state weight
- Updates probability calculation to use actual weight values instead of hardcoded constants
j-i-k-o
approved these changes
Aug 1, 2025
Collaborator
j-i-k-o
left a comment
j-i-k-o
left a comment
There was a problem hiding this comment.
https://www.kurims.kyoto-u.ac.jp/~kyodo/kokyuroku/contents/pdf/1848-09.pdf の文献の(10)式のことと解釈しました。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
諏訪藤堂法のアルゴリズムにバグがあったので直したました。
オーバーフローを避けるために確率を定数倍していたことを考慮できていなかったので直しました。