Fix suwa-todo method and improve heatbath method#496
Merged
K-Suzuki-Jij merged 1 commit intomainfrom Aug 7, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the performance of two optimization methods in OpenJij by fixing a bug in the Suwa-Todo method and replacing the Gumbel-Max Trick implementation in the heatbath method with a more efficient cumulative sum approach.
- Fixed numerical precision bug in Suwa-Todo method by changing strict inequality to less-than-or-equal comparison
- Replaced Gumbel-Max Trick with direct cumulative probability calculation in heatbath method for better performance
- Removed unnecessary arrays and simplified logic in Suwa-Todo method for optimization
j-i-k-o
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変更